Issue 2658463003: Rename function to avoid unintentional override

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2658463003: Rename function to avoid unintentional override (Closed)

Created:
3 years, 11 months ago by gogerald1

Modified:
3 years, 11 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

Rename function to avoid unintentional override isValid in AutofillPaymentInstrument overrides isValid in PaymentOption unintentionally, BUG=684613 Review-Url: https://codereview.chromium.org/2652063002 Cr-Commit-Position: refs/heads/master@{#445842} (cherry picked from commit ac8115d65b026823fc338ca7f9afd8412fa20b81) Review-Url: https://codereview.chromium.org/2658463003 . Cr-Commit-Position: refs/branch-heads/2987@{#85} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/404743c535686b18dc35a62892a2481c72bce589

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

gogerald1

3 years, 11 months ago (2017-01-25 14:50:47 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
404743c535686b18dc35a62892a2481c72bce589.