Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2652063002: [Payments] Rename function to avoid unintentional override (Closed)

Created:
3 years, 11 months ago by gogerald1
Modified:
3 years, 11 months ago
CC:
chromium-reviews, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, gogerald+paymentswatch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename function to avoid unintentional override isValid in AutofillPaymentInstrument overrides isValid in PaymentOption unintentionally, BUG=684613 Review-Url: https://codereview.chromium.org/2652063002 Cr-Commit-Position: refs/heads/master@{#445842} Committed: https://chromium.googlesource.com/chromium/src/+/ac8115d65b026823fc338ca7f9afd8412fa20b81

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/AutofillPaymentInstrument.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
gogerald1
Hi rouslan@, PTAL,
3 years, 11 months ago (2017-01-24 20:23:23 UTC) #5
please use gerrit instead
lgtm
3 years, 11 months ago (2017-01-24 20:31:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652063002/1
3 years, 11 months ago (2017-01-24 21:01:31 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/199293)
3 years, 11 months ago (2017-01-24 21:24:08 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2652063002/1
3 years, 11 months ago (2017-01-24 22:01:51 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 22:30:00 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ac8115d65b026823fc338ca7f9af...

Powered by Google App Engine
This is Rietveld 408576698