Issue 2658133003: Include build/build_config.h in all component updater files.

Issue 2658133003: Include build/build_config.h in all component updater files. (Closed)

Created:
3 years, 10 months ago by Sorin Jianu

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

Include build/build_config.h in all component updater files. All files using conditional compilation must include the build_config, otherwise the platform symbols are not defined. Merged to M56. BUG=684950 Review-Url: https://codereview.chromium.org/2655813002 Cr-Commit-Position: refs/heads/master@{#446050} (cherry picked from commit 96d71e0c6c152a39ee9b452c96428af7cc4520bc) Review-Url: https://codereview.chromium.org/2658133003 . Cr-Commit-Position: refs/branch-heads/2924@{#878} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/fb55e5c0df12ced401f5ccb1309bd3ac7fde0e65

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -6 lines)			Patch
M	chrome/browser/component_updater/chrome_component_updater_configurator.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/component_updater/component_updater_utils.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	components/update_client/update_checker_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	components/update_client/updater_state.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	components/update_client/updater_state_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Sorin Jianu

3 years, 10 months ago (2017-01-27 18:29:19 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fb55e5c0df12ced401f5ccb1309bd3ac7fde0e65.