Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2655813002: Include build/build_config.h in all component updater files. (Closed)

Created:
3 years, 11 months ago by Sorin Jianu
Modified:
3 years, 11 months ago
Reviewers:
waffles
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Include build/build_config.h in all component updater files. All files using conditional compilation must include the build_config, otherwise the platform symbols are not defined. BUG=684950 Review-Url: https://codereview.chromium.org/2655813002 Cr-Commit-Position: refs/heads/master@{#446050} Committed: https://chromium.googlesource.com/chromium/src/+/96d71e0c6c152a39ee9b452c96428af7cc4520bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -6 lines) Patch
M chrome/browser/component_updater/chrome_component_updater_configurator.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/component_updater/component_updater_utils.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/update_client/update_checker_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/update_client/updater_state.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/update_client/updater_state_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Sorin Jianu
PTAL
3 years, 11 months ago (2017-01-25 03:27:52 UTC) #4
waffles
lgtm
3 years, 11 months ago (2017-01-25 17:31:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2655813002/1
3 years, 11 months ago (2017-01-25 17:32:13 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 17:39:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/96d71e0c6c152a39ee9b452c9642...

Powered by Google App Engine
This is Rietveld 408576698