Fix cups manufacturer and model dropdowns.

Fix cups manufacturer and model dropdowns.

Right now if you click on the little "open me up" arrow in these boxes nothing happens.  This makes that action bring up the relevant lists.

Note this may not be entirely the right answer for how this UI element should work, but I believe it's a strict improvement over the status quo.

BUG=chromium:685842
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2658063004
Cr-Commit-Position: refs/heads/master@{#459214}
Committed: https://chromium.googlesource.com/chromium/src/+/942ef62b8eb39ebd5ca23b0bce07bc0297e20499

[Carlson, 2017-01-26 23:33:04]

Description was changed from

==========
Fix cups manufacturer and model dropdowns.

Right now if you click on the little "open me up" arrow in these boxes nothing
happens.  This makes that action bring up the relevant lists.

Note this may not be entirely the right answer for how this UI element should
work, but I believe it's a strict improvement over the status quo.

BUG=chromium:685842
==========

to

==========
Fix cups manufacturer and model dropdowns.

Right now if you click on the little "open me up" arrow in these boxes nothing
happens.  This makes that action bring up the relevant lists.

Note this may not be entirely the right answer for how this UI element should
work, but I believe it's a strict improvement over the status quo.

BUG=chromium:685842
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Carlson, 2017-01-26 23:34:24]

Description was changed from

==========
Fix cups manufacturer and model dropdowns.

Right now if you click on the little "open me up" arrow in these boxes nothing
happens.  This makes that action bring up the relevant lists.

Note this may not be entirely the right answer for how this UI element should
work, but I believe it's a strict improvement over the status quo.

BUG=chromium:685842
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix cups manufacturer and model dropdowns.

Right now if you click on the little "open me up" arrow in these boxes nothing
happens.  This makes that action bring up the relevant lists.

Note this may not be entirely the right answer for how this UI element should
work, but I believe it's a strict improvement over the status quo.

BUG=chromium:685842
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Carlson, 2017-01-26 23:34:24]

justincarlson@chromium.org changed reviewers:
+ xdai@chromium.org

[xdai1, 2017-01-26 23:40:21]

On 2017/01/26 23:34:29, Carlson wrote:

lgtm

[Carlson, 2017-01-27 18:41:18]

The CQ bit was checked by justincarlson@chromium.org

[commit-bot: I haz the power, 2017-01-27 18:41:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-27 18:52:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-27 18:52:25]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Carlson, 2017-01-27 19:27:21]

justincarlson@chromium.org changed reviewers:
+ dpapad@chromium.org

[Carlson, 2017-01-27 19:28:24]

On 2017/01/27 18:52:25, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dpapad, 2017-01-27 22:24:25]

https://codereview.chromium.org/2658063004/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
(right):

https://codereview.chromium.org/2658063004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html:65:
on-tap="onTap_">
Instead of adding the onTap_ listener three times, could you add it in the
parent element <paper-input-container> instead, once?

[Dan Beam, 2017-01-27 22:50:32]

https://codereview.chromium.org/2658063004/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
(right):

https://codereview.chromium.org/2658063004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html:65:
on-tap="onTap_">
On 2017/01/27 22:24:25, dpapad wrote:
> Instead of adding the onTap_ listener three times, could you add it in the
> parent element <paper-input-container> instead, once?

+1, yeah, that seems cleaner

[Carlson, 2017-01-31 18:39:34]

https://codereview.chromium.org/2658063004/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html
(right):

https://codereview.chromium.org/2658063004/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html:65:
on-tap="onTap_">
On 2017/01/27 22:50:32, Dan Beam wrote:
> On 2017/01/27 22:24:25, dpapad wrote:
> > Instead of adding the onTap_ listener three times, could you add it in the
> > parent element <paper-input-container> instead, once?
> 
> +1, yeah, that seems cleaner

Good idea, done.

[dpapad, 2017-01-31 19:28:02]

LGTM. FWIW, I would consider adding tests to ensure this will not regress. There
are already some CUPS related tests at
https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/cups_pri...,
but none of them refer to the <drop-down-search-box>  element.

[dpapad, 2017-02-22 00:02:23]

On 2017/01/31 at 19:28:02, dpapad wrote:
> LGTM. FWIW, I would consider adding tests to ensure this will not regress.
There are already some CUPS related tests at
https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/cups_pri...,
but none of them refer to the <drop-down-search-box>  element.

What is the status of this CL?

[Carlson, 2017-02-22 00:24:59]

On 2017/02/22 00:02:23, dpapad wrote:
> On 2017/01/31 at 19:28:02, dpapad wrote:
> > LGTM. FWIW, I would consider adding tests to ensure this will not regress.
> There are already some CUPS related tests at
>
https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/cups_pri...,
> but none of them refer to the <drop-down-search-box>  element.
> 
> What is the status of this CL?

It's low enough priority that I haven't made time to do unit tests.  Not sure
when I'll come back to it.

[Carlson, 2017-03-23 17:35:21]

On 2017/02/22 00:24:59, Carlson wrote:
> On 2017/02/22 00:02:23, dpapad wrote:
> > On 2017/01/31 at 19:28:02, dpapad wrote:
> > > LGTM. FWIW, I would consider adding tests to ensure this will not regress.
> > There are already some CUPS related tests at
> >
>
https://cs.chromium.org/chromium/src/chrome/test/data/webui/settings/cups_pri...,
> > but none of them refer to the <drop-down-search-box>  element.
> > 
> > What is the status of this CL?
> 
> It's low enough priority that I haven't made time to do unit tests.  Not sure
> when I'll come back to it.

I'm still stacked up with other stuff, but users are actually hitting this bug. 
Filed crbug.com/704347 to add a unit test, but am going to submit this as-is
unless there are objections.

[Carlson, 2017-03-23 17:45:39]

The CQ bit was checked by justincarlson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 17:46:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 18:34:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 18:34:07]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Carlson, 2017-03-23 18:37:30]

The CQ bit was checked by justincarlson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-23 18:38:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 18:52:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-23 18:52:30]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Carlson, 2017-03-23 20:10:01]

The CQ bit was checked by justincarlson@chromium.org

[Carlson, 2017-03-23 20:10:02]

The patchset sent to the CQ was uploaded after l-g-t-m from xdai@chromium.org,
dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2658063004/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-23 20:10:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 21:05:38]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490299801815930,
"parent_rev": "e8caf7c191831e7272edede1ed32508557a2ce20", "commit_rev":
"942ef62b8eb39ebd5ca23b0bce07bc0297e20499"}

[commit-bot: I haz the power, 2017-03-23 21:06:23]

Description was changed from

==========
Fix cups manufacturer and model dropdowns.

Right now if you click on the little "open me up" arrow in these boxes nothing
happens.  This makes that action bring up the relevant lists.

Note this may not be entirely the right answer for how this UI element should
work, but I believe it's a strict improvement over the status quo.

BUG=chromium:685842
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix cups manufacturer and model dropdowns.

Right now if you click on the little "open me up" arrow in these boxes nothing
happens.  This makes that action bring up the relevant lists.

Note this may not be entirely the right answer for how this UI element should
work, but I believe it's a strict improvement over the status quo.

BUG=chromium:685842
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2658063004
Cr-Commit-Position: refs/heads/master@{#459214}
Committed:
https://chromium.googlesource.com/chromium/src/+/942ef62b8eb39ebd5ca23b0bce07...
==========

[commit-bot: I haz the power, 2017-03-23 21:06:24]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/942ef62b8eb39ebd5ca23b0bce07...