Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Side by Side Diff: chrome/browser/resources/settings/printing_page/cups_add_printer_dialog_util.html

Issue 2658063004: Fix cups manufacturer and model dropdowns. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html "> 1 <link rel="import" href="chrome://resources/cr_elements/cr_dialog/cr_dialog.html ">
2 <link rel="import" href="chrome://resources/cr_elements/icons.html"> 2 <link rel="import" href="chrome://resources/cr_elements/icons.html">
3 <link rel="import" href="chrome://resources/html/polymer.html"> 3 <link rel="import" href="chrome://resources/html/polymer.html">
4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-dropdown/iron-drop down.html"> 4 <link rel="import" href="chrome://resources/polymer/v1_0/iron-dropdown/iron-drop down.html">
5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-input/iron-input.h tml"> 5 <link rel="import" href="chrome://resources/polymer/v1_0/iron-input/iron-input.h tml">
6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> 6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html"> 7 <link rel="import" href="chrome://resources/polymer/v1_0/paper-icon-button/paper -icon-button.html">
8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input -container.html"> 8 <link rel="import" href="chrome://resources/polymer/v1_0/paper-input/paper-input -container.html">
9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml"> 9 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">
10 <link rel="import" href="/printing_page/cups_printers_browser_proxy.html"> 10 <link rel="import" href="/printing_page/cups_printers_browser_proxy.html">
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 }; 51 };
52 } 52 }
53 53
54 iron-dropdown .dropdown-content paper-item { 54 iron-dropdown .dropdown-content paper-item {
55 min-height: 40px; 55 min-height: 40px;
56 } 56 }
57 </style> 57 </style>
58 <paper-input-container no-label-float> 58 <paper-input-container no-label-float>
59 <input is="iron-input" type="search" on-tap="onTap_" 59 <input is="iron-input" type="search" on-tap="onTap_"
60 on-search="onInputValueChanged_" on-change="onChange_" incremental> 60 on-search="onInputValueChanged_" on-change="onChange_" incremental>
61 <paper-icon-button suffix id="searchIcon" icon="cr:search" hidden> 61 <paper-icon-button suffix id="searchIcon" icon="cr:search" on-tap="onTap_"
62 hidden>
62 </paper-icon-button> 63 </paper-icon-button>
63 <paper-icon-button suffix id="dropdownIcon" icon="cr:arrow-drop-down"> 64 <paper-icon-button suffix id="dropdownIcon" icon="cr:arrow-drop-down"
65 on-tap="onTap_">
dpapad 2017/01/27 22:24:25 Instead of adding the onTap_ listener three times,
Dan Beam 2017/01/27 22:50:32 +1, yeah, that seems cleaner
Carlson 2017/01/31 18:39:34 Good idea, done.
64 </paper-icon-button> 66 </paper-icon-button>
65 </paper-input-container> 67 </paper-input-container>
66 <iron-dropdown horizontal-align="left" vertical-align="top" 68 <iron-dropdown horizontal-align="left" vertical-align="top"
67 vertical-offset="47"> 69 vertical-offset="47">
68 <div class="dropdown-content"> 70 <div class="dropdown-content">
69 <template is="dom-repeat" items="[[items]]" 71 <template is="dom-repeat" items="[[items]]"
70 filter="[[filterItems_(searchTerm_)]]"> 72 filter="[[filterItems_(searchTerm_)]]">
71 <paper-item on-tap="onSelect_">[[item]]</paper-item> 73 <paper-item on-tap="onSelect_">[[item]]</paper-item>
72 </template> 74 </template>
73 </div> 75 </div>
(...skipping 29 matching lines...) Expand all
103 <div class="body"> 105 <div class="body">
104 <content select=".dialog-body"></content> 106 <content select=".dialog-body"></content>
105 </div> 107 </div>
106 <div class="button-container"> 108 <div class="button-container">
107 <content select=".dialog-buttons"></content> 109 <content select=".dialog-buttons"></content>
108 </div> 110 </div>
109 </dialog> 111 </dialog>
110 </template> 112 </template>
111 <script src="cups_add_printer_dialog_util.js"></script> 113 <script src="cups_add_printer_dialog_util.js"></script>
112 </dom-module> 114 </dom-module>
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698