Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2658023002:
Add a fixed delay in history before opening tool menu (Closed)
DescriptionAdd a fixed delay in history before opening tool menu
The animation of the NTP is not taken into account by Earl Grey.
This CL adds a delay to make sure the toolmenu can be interacted with.
BUG=685570
Review-Url: https://codereview.chromium.org/2658023002
Cr-Commit-Position: refs/heads/master@{#446297}
Committed: https://chromium.googlesource.com/chromium/src/+/c0f80f1c19257bfd18968479860caa0640bbca83
Patch Set 1 #
Total comments: 4
Patch Set 2 : Address comments #Messages
Total messages: 16 (9 generated)
gambard@chromium.org changed reviewers: + baxley@chromium.org, lpromero@chromium.org
baxley@: TBR lpromero: PTAL.
The CQ bit was checked by gambard@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm https://codereview.chromium.org/2658023002/diff/1/ios/chrome/browser/ui/histo... File ios/chrome/browser/ui/history/history_ui_egtest.mm (right): https://codereview.chromium.org/2658023002/diff/1/ios/chrome/browser/ui/histo... ios/chrome/browser/ui/history/history_ui_egtest.mm:478: // TODO:(crbug.com/685570) Fix the tap instead of adding a delay. The style if "// TODO(crbug.com/685570): Fix…"
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2658023002/diff/1/ios/chrome/browser/ui/histo... File ios/chrome/browser/ui/history/history_ui_egtest.mm (right): https://codereview.chromium.org/2658023002/diff/1/ios/chrome/browser/ui/histo... ios/chrome/browser/ui/history/history_ui_egtest.mm:484: [myCondition waitWithTimeout:0.5]; How many tests do we have? Adding 0.5 seconds to almost each is pretty costly. Locally did you reproduce breakage/flakiness, fixed by this? Can you try smaller values?
https://codereview.chromium.org/2658023002/diff/1/ios/chrome/browser/ui/histo... File ios/chrome/browser/ui/history/history_ui_egtest.mm (right): https://codereview.chromium.org/2658023002/diff/1/ios/chrome/browser/ui/histo... ios/chrome/browser/ui/history/history_ui_egtest.mm:484: [myCondition waitWithTimeout:0.5]; On 2017/01/26 10:17:07, lpromero wrote: > How many tests do we have? Adding 0.5 seconds to almost each is pretty costly. > > Locally did you reproduce breakage/flakiness, fixed by this? Can you try smaller > values? I will add them to the failing tests only. There is 2 or 3 of them, so the cost should be manageable.
Thanks! https://codereview.chromium.org/2658023002/diff/1/ios/chrome/browser/ui/histo... File ios/chrome/browser/ui/history/history_ui_egtest.mm (right): https://codereview.chromium.org/2658023002/diff/1/ios/chrome/browser/ui/histo... ios/chrome/browser/ui/history/history_ui_egtest.mm:478: // TODO:(crbug.com/685570) Fix the tap instead of adding a delay. On 2017/01/26 10:15:53, lpromero wrote: > The style if "// TODO(crbug.com/685570): Fix…" Done.
The CQ bit was checked by gambard@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lpromero@chromium.org Link to the patchset: https://codereview.chromium.org/2658023002/#ps20001 (title: "Address comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485426599084920,
"parent_rev": "fa79433c416ae90a8d1cdf5292e1b02785058efd", "commit_rev":
"c0f80f1c19257bfd18968479860caa0640bbca83"}
Message was sent while issue was closed.
Description was changed from ========== Add a fixed delay in history before opening tool menu The animation of the NTP is not taken into account by Earl Grey. This CL adds a delay to make sure the toolmenu can be interacted with. BUG=685570 ========== to ========== Add a fixed delay in history before opening tool menu The animation of the NTP is not taken into account by Earl Grey. This CL adds a delay to make sure the toolmenu can be interacted with. BUG=685570 Review-Url: https://codereview.chromium.org/2658023002 Cr-Commit-Position: refs/heads/master@{#446297} Committed: https://chromium.googlesource.com/chromium/src/+/c0f80f1c19257bfd18968479860c... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/c0f80f1c19257bfd18968479860c... |
