Add a fixed delay in history before opening tool menu

ios/chrome/browser/ui/history/history_ui_egtest.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <EarlGrey/EarlGrey.h>
 #import <UIKit/UIKit.h>
 #import <XCTest/XCTest.h>
 
 #include "base/strings/sys_string_conversions.h"
 #include "components/browsing_data/core/pref_names.h"
@@ skipping 457 matching lines @@
       assertWithMatcher:grey_notNil()];
 
   [ChromeEarlGrey loadURL:_URL3];
   id<GREYMatcher> response3Matcher =
       chrome_test_util::WebViewContainingText(kResponse3);
   [[EarlGrey selectElementWithMatcher:response3Matcher]
       assertWithMatcher:grey_notNil()];
 }
 
 - (void)openHistoryPanel {
+  // TODO:(crbug.com/685570) Fix the tap instead of adding a delay.

[lpromero, 2017/01/26 10:15:53]

The style if "// TODO(crbug.com/685570): Fix…" 

[gambard, 2017/01/26 10:29:54]

Done.

+  GREYCondition* myCondition = [GREYCondition
+      conditionWithName:@"Delay to ensure the toolbar menu can be opened"
+                  block:^BOOL {
+                    return NO;
+                  }];
+  [myCondition waitWithTimeout:0.5];

[lpromero, 2017/01/26 10:17:07]

How many tests do we have? Adding 0.5 seconds to almost each is pretty costly.

Locally did you reproduce breakage/flakiness, fixed by this? Can you try smaller
values?

[gambard, 2017/01/26 10:19:04]

I will add them to the failing tests only. There is 2 or 3 of them, so the cost
should be manageable.

+
   [ChromeEarlGreyUI openToolsMenu];
   [[EarlGrey selectElementWithMatcher:HistoryButton()]
       performAction:grey_tap()];
 }
 
 - (void)assertNoHistoryShown {
   id<GREYMatcher> noHistoryMessageMatcher =
       grey_allOf(grey_text(l10n_util::GetNSString(IDS_HISTORY_NO_RESULTS)),
                  grey_sufficientlyVisible(), nil);
   [[EarlGrey selectElementWithMatcher:noHistoryMessageMatcher]
       assertWithMatcher:grey_notNil()];
 
   id<GREYMatcher> historyEntryMatcher =
       grey_allOf(grey_kindOfClass([HistoryEntryCell class]),
                  grey_sufficientlyVisible(), nil);
   [[EarlGrey selectElementWithMatcher:historyEntryMatcher]
       assertWithMatcher:grey_nil()];
 }
 
 - (void)resetBrowsingDataPrefs {
   PrefService* prefs = chrome_test_util::GetOriginalBrowserState()->GetPrefs();
   prefs->ClearPref(browsing_data::prefs::kDeleteBrowsingHistory);
   prefs->ClearPref(browsing_data::prefs::kDeleteCookies);
   prefs->ClearPref(browsing_data::prefs::kDeleteCache);
   prefs->ClearPref(browsing_data::prefs::kDeletePasswords);
   prefs->ClearPref(browsing_data::prefs::kDeleteFormData);
 }
 
 @end