Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: chrome/browser/chromeos/login/screens/reset_screen.h

Issue 2657953005: cros: Fold ResetModel into ResetScreen (Closed)
Patch Set: Rebase, address comment Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/screens/reset_screen.h
diff --git a/chrome/browser/chromeos/login/screens/reset_screen.h b/chrome/browser/chromeos/login/screens/reset_screen.h
index 40fac933e8c4ee97316713b43be2bb7caaf68114..77740e6075cb5aeadfc2712896f354b31bd3ef52 100644
--- a/chrome/browser/chromeos/login/screens/reset_screen.h
+++ b/chrome/browser/chromeos/login/screens/reset_screen.h
@@ -12,7 +12,7 @@
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
#include "chrome/browser/chromeos/login/help_app_launcher.h"
-#include "chrome/browser/chromeos/login/screens/reset_model.h"
+#include "chrome/browser/chromeos/login/screens/base_screen.h"
#include "chromeos/dbus/update_engine_client.h"
@@ -22,17 +22,19 @@ class ErrorScreen;
class ResetView;
// Representation independent class that controls screen showing reset to users.
-class ResetScreen : public ResetModel,
- public UpdateEngineClient::Observer {
+class ResetScreen : public BaseScreen, public UpdateEngineClient::Observer {
public:
ResetScreen(BaseScreenDelegate* base_screen_delegate,
ResetView* view);
~ResetScreen() override;
- // ResetModel implementation:
+ // Called when actor is destroyed so there's no dead reference to it.
+ void OnViewDestroyed(ResetView* view);
+
+ private:
+ // BaseScreen implementation:
void Show() override;
void Hide() override;
- void OnViewDestroyed(ResetView* view) override;
void OnUserAction(const std::string& action_id) override;
// UpdateEngineClient::Observer implementation:
@@ -40,8 +42,6 @@ class ResetScreen : public ResetModel,
void OnRollbackCheck(bool can_rollback);
- private:
-
enum State {
STATE_RESTART_REQUIRED = 0,
STATE_REVERT_PROMISE,
« no previous file with comments | « chrome/browser/chromeos/login/screens/reset_model.cc ('k') | chrome/browser/chromeos/login/screens/reset_screen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698