Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2657943006: Move webkit-patch bash completion to tools/bash-completion. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 10 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, chromium-reviews, Ɓukasz Anforowicz
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move webkit-patch bash completion to tools/bash-completion. Most of the contents of webkit-tools-completion.sh is now irrelevant, but there was some logic for webkit-patch command completion there. This CL doesn't copy it over, but adds some basic completion for webkit-patch to tools/bash-completion. Thanks to lukasza@, there is already completion for run-webkit-tests there (added in https://codereview.chromium.org/2435893002). This also makes a minor change to bash-completion to make it work for zsh as well (if $BASH_SOURCE is undefined, use $0 instead). BUG=660890 Review-Url: https://codereview.chromium.org/2657943006 Cr-Commit-Position: refs/heads/master@{#446551} Committed: https://chromium.googlesource.com/chromium/src/+/85380c97c1bc176e8f40f0649cf21e419d036316

Patch Set 1 #

Patch Set 2 : Move webkit-patch command completion to tools/bash-completion #

Patch Set 3 : - #

Patch Set 4 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -79 lines) Patch
D third_party/WebKit/Tools/Scripts/webkit-tools-completion.sh View 1 chunk +0 lines, -78 lines 0 comments Download
M tools/bash-completion View 1 2 3 3 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
qyearsley
3 years, 11 months ago (2017-01-26 23:00:20 UTC) #4
Dirk Pranke
lgtm. You should probably send a PSA out to blink-dev warning them that the file ...
3 years, 11 months ago (2017-01-27 00:18:07 UTC) #5
qyearsley
On 2017/01/27 at 00:18:07, dpranke wrote: > lgtm. You should probably send a PSA out ...
3 years, 11 months ago (2017-01-27 00:40:09 UTC) #6
qyearsley
On 2017/01/27 at 00:40:09, qyearsley wrote: > On 2017/01/27 at 00:18:07, dpranke wrote: > > ...
3 years, 11 months ago (2017-01-27 00:55:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657943006/60001
3 years, 11 months ago (2017-01-27 00:56:45 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 02:47:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/85380c97c1bc176e8f40f0649cf2...

Powered by Google App Engine
This is Rietveld 408576698