Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2435893002: Bash completion support for run-webkit-tests (i.e. for layout tests). (Closed)

Created:
4 years, 2 months ago by Łukasz Anforowicz
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke, enne (OOO)
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Bash completion support for run-webkit-tests (i.e. for layout tests). BUG=none Committed: https://crrev.com/ca7fac6224aa67bd9b11941c498a22995b2b27c9 Cr-Commit-Position: refs/heads/master@{#427768}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -0 lines) Patch
M tools/bash-completion View 3 chunks +44 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (4 generated)
Łukasz Anforowicz
enne@, can you PTAL at another bash-completion CL? (last one I think :-).
4 years, 2 months ago (2016-10-20 15:21:34 UTC) #2
enne (OOO)
lgtm
4 years, 2 months ago (2016-10-20 18:14:36 UTC) #3
Łukasz Anforowicz
dpranke@, can you please do an OWNERS review?
4 years, 2 months ago (2016-10-20 18:22:46 UTC) #4
Łukasz Anforowicz
Dirk, can you do an OWNERS review please? (oops, I think I've forgotten to actually ...
4 years, 2 months ago (2016-10-21 23:08:34 UTC) #5
Łukasz Anforowicz
Really adding Dirk this time...
4 years, 2 months ago (2016-10-21 23:08:52 UTC) #7
Dirk Pranke
lgtm, sorry for the delay.
4 years, 1 month ago (2016-10-26 18:46:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2435893002/1
4 years, 1 month ago (2016-10-26 18:48:21 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 18:59:44 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 19:22:18 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca7fac6224aa67bd9b11941c498a22995b2b27c9
Cr-Commit-Position: refs/heads/master@{#427768}

Powered by Google App Engine
This is Rietveld 408576698