Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6325)

Unified Diff: chrome/browser/extensions/external_pref_loader.cc

Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver. (Closed)
Patch Set: Add SyncService* to OnStateChanged Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/external_pref_loader.cc
diff --git a/chrome/browser/extensions/external_pref_loader.cc b/chrome/browser/extensions/external_pref_loader.cc
index 1d257b23a7c1e480860e363ffd4311e5bf0e4583..971aae56b8017802bb120a5c7acff46489b87b5d 100644
--- a/chrome/browser/extensions/external_pref_loader.cc
+++ b/chrome/browser/extensions/external_pref_loader.cc
@@ -154,7 +154,7 @@ void ExternalPrefLoader::OnIsSyncingChanged() {
PostLoadIfPrioritySyncReady();
}
-void ExternalPrefLoader::OnStateChanged() {
+void ExternalPrefLoader::OnStateChanged(syncer::SyncService* sync) {
browser_sync::ProfileSyncService* service =
skym 2017/01/26 23:43:22 This variable can be replaced by |sync|.
Steven Holte 2017/01/27 02:27:19 Done.
ProfileSyncServiceFactory::GetForProfile(profile_);
DCHECK(service);
skym 2017/01/26 23:43:23 I'd remove the DCHECK as well while you're in here
Steven Holte 2017/01/27 02:27:19 Done.

Powered by Google App Engine
This is Rietveld 408576698