chrome/browser/chromeos/login/signin/auth_sync_observer.cc - Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/signin/auth_sync_observer.cc

Issue 2657673004: Add shutdown notification and service refs to SyncServiceObserver. (Closed)

Patch Set: Add SyncService* to OnStateChanged Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/signin/auth_sync_observer.cc

diff --git a/chrome/browser/chromeos/login/signin/auth_sync_observer.cc b/chrome/browser/chromeos/login/signin/auth_sync_observer.cc

index f95b305cd491e5213c76559350fef29eb8dccbcb..8313c79555286443c32b877681dad97f6e4281d4 100644

--- a/chrome/browser/chromeos/login/signin/auth_sync_observer.cc

+++ b/chrome/browser/chromeos/login/signin/auth_sync_observer.cc

@@ -47,7 +47,7 @@ void AuthSyncObserver::Shutdown() {

sync_service->RemoveObserver(this);

}

-void AuthSyncObserver::OnStateChanged() {

+void AuthSyncObserver::OnStateChanged(syncer::SyncService* sync) {

DCHECK(user_manager::UserManager::Get()->IsLoggedInAsUserWithGaiaAccount() ||

user_manager::UserManager::Get()->IsLoggedInAsSupervisedUser());

browser_sync::ProfileSyncService* sync_service =

skym 2017/01/26 23:43:22 This variable can be replaced by |sync|.

Steven Holte 2017/01/27 02:27:19 Done.