Add shutdown notification and service refs to SyncServiceObserver.

chrome/browser/extensions/external_pref_loader.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/external_pref_loader.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/files/file_enumerator.h"
@@ skipping 136 matching lines @@
     BrowserThread::PostTask(
         BrowserThread::FILE, FROM_HERE,
         base::Bind(&ExternalPrefLoader::LoadOnFileThread, this));
   }
 }
 
 void ExternalPrefLoader::OnIsSyncingChanged() {
   PostLoadIfPrioritySyncReady();
 }
 
-void ExternalPrefLoader::OnStateChanged() {
+void ExternalPrefLoader::OnStateChanged(syncer::SyncService* sync) {
   browser_sync::ProfileSyncService* service =

[skym, 2017/01/26 23:43:22]

This variable can be replaced by |sync|.

[Steven Holte, 2017/01/27 02:27:19]

Done.

       ProfileSyncServiceFactory::GetForProfile(profile_);
   DCHECK(service);

[skym, 2017/01/26 23:43:23]

I'd remove the DCHECK as well while you're in here.

[Steven Holte, 2017/01/27 02:27:19]

Done.

   if (!service->CanSyncStart()) {
     PostLoadAndRemoveObservers();
   }
 }
 
 bool ExternalPrefLoader::PostLoadIfPrioritySyncReady() {
   DCHECK(options_ & DELAY_LOAD_UNTIL_PRIORITY_SYNC);
   DCHECK(profile_);
 
   sync_preferences::PrefServiceSyncable* prefs =
@@ skipping 159 matching lines @@
   LoadFinished();
 }
 
 ExternalTestingLoader::~ExternalTestingLoader() {}
 
 const base::FilePath ExternalTestingLoader::GetBaseCrxFilePath() {
   return fake_base_path_;
 }
 
 }  // namespace extensions