Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2657613004: Use explicit WebString conversions in translate code (Closed)

Created:
3 years, 11 months ago by kinuko
Modified:
3 years, 11 months ago
Reviewers:
Takashi Toyoshima
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use explicit WebString conversions in plugins code As we're deprecating implicit conversions for WebString <-> string16 replace them with explicit methods. (See crbug.com/667131 for more details) BUG=667131 R=toyoshim@chromium.org Review-Url: https://codereview.chromium.org/2657613004 Cr-Commit-Position: refs/heads/master@{#446284} Committed: https://chromium.googlesource.com/chromium/src/+/7bab3265dc08756009c0374803bbbdd11fa6a1e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M chrome/renderer/translate/translate_script_browsertest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M components/translate/content/renderer/translate_helper.cc View 5 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
kinuko
Mechanical changes only-- PTL!
3 years, 11 months ago (2017-01-25 12:43:57 UTC) #3
kinuko
On 2017/01/25 12:43:57, kinuko wrote: > Mechanical changes only-- PTL! Sorry, issue subject was wrong... ...
3 years, 11 months ago (2017-01-25 13:19:59 UTC) #5
kinuko
Friendly ping, this is awaiting for your review :)
3 years, 11 months ago (2017-01-26 03:11:09 UTC) #8
Takashi Toyoshima
oops, sorry I didn't notice this CL. LGTM!
3 years, 11 months ago (2017-01-26 09:17:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657613004/1
3 years, 11 months ago (2017-01-26 09:33:38 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 09:38:35 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7bab3265dc08756009c0374803bb...

Powered by Google App Engine
This is Rietveld 408576698