Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Unified Diff: chrome/renderer/translate/translate_script_browsertest.cc

Issue 2657613004: Use explicit WebString conversions in translate code (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/translate/content/renderer/translate_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/translate/translate_script_browsertest.cc
diff --git a/chrome/renderer/translate/translate_script_browsertest.cc b/chrome/renderer/translate/translate_script_browsertest.cc
index bdc106190803ebd46ec6e6c01d4aa8faa450e047..96b2971637eae52ebfdd66564d6f9dc6997765e7 100644
--- a/chrome/renderer/translate/translate_script_browsertest.cc
+++ b/chrome/renderer/translate/translate_script_browsertest.cc
@@ -88,7 +88,8 @@ class TranslateScriptBrowserTest : public ChromeRenderViewTest {
}
void ExecuteScript(const std::string& script) {
- WebScriptSource source = WebScriptSource(base::ASCIIToUTF16(script));
+ WebScriptSource source =
+ WebScriptSource(blink::WebString::fromASCII(script));
GetMainFrame()->executeScript(source);
}
@@ -110,7 +111,8 @@ class TranslateScriptBrowserTest : public ChromeRenderViewTest {
void TearDown() override { ChromeRenderViewTest::TearDown(); }
double ExecuteScriptAndGetNumberResult(const std::string& script) {
- WebScriptSource source = WebScriptSource(base::ASCIIToUTF16(script));
+ WebScriptSource source =
+ WebScriptSource(blink::WebString::fromASCII(script));
v8::HandleScope handle_scope(v8::Isolate::GetCurrent());
v8::Local<v8::Value> result =
GetMainFrame()->executeScriptAndReturnValue(source);
@@ -124,7 +126,8 @@ class TranslateScriptBrowserTest : public ChromeRenderViewTest {
}
bool ExecuteScriptAndGetBoolResult(const std::string& script) {
- WebScriptSource source = WebScriptSource(base::ASCIIToUTF16(script));
+ WebScriptSource source =
+ WebScriptSource(blink::WebString::fromASCII(script));
v8::HandleScope handle_scope(v8::Isolate::GetCurrent());
v8::Local<v8::Value> result =
GetMainFrame()->executeScriptAndReturnValue(source);
« no previous file with comments | « no previous file | components/translate/content/renderer/translate_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698