Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2657533008: Merge "Fix double-close in EventConverterEvdevImpl" (Closed)

Created:
3 years, 11 months ago by xiyuan
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Merge "Fix double-close in EventConverterEvdevImpl" > This fixes a double close that occurs when a keyboard or mouse is > unplugged from the system, which will cause breakage if there is a > concurrent open(). It also switches to a scoped file descriptor wrapper, > with a special close function because close() can return ENODEV on an > input device that was unplugged. > > BUG=681865, 660960 > TEST=events_unittests > > Review-Url: https://codereview.chromium.org/2639043002 > Cr-Commit-Position: refs/heads/master@{#444544} > (cherry picked from commit 13ad1ff07b21ed9f4b7b5cb7c7cebdff0b8fe0c1) Review-Url: https://codereview.chromium.org/2657533008 . Cr-Commit-Position: refs/branch-heads/2924@{#863} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/df2217a1a4a5803474b51bd59a1f4ca11160c21d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -69 lines) Patch
M ui/events/ozone/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl.h View 3 chunks +5 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/events/ozone/evdev/event_converter_evdev_impl_unittest.cc View 5 chunks +9 lines, -10 lines 0 comments Download
M ui/events/ozone/evdev/input_device_factory_evdev.cc View 5 chunks +16 lines, -14 lines 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/event_reader_libevdev_cros.cc View 3 chunks +3 lines, -4 lines 0 comments Download
A ui/events/ozone/evdev/scoped_input_device.h View 1 chunk +25 lines, -0 lines 0 comments Download
A ui/events/ozone/evdev/scoped_input_device.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M ui/events/ozone/evdev/tablet_event_converter_evdev.h View 3 chunks +5 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/tablet_event_converter_evdev.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/tablet_event_converter_evdev_unittest.cc View 5 chunks +13 lines, -14 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.h View 3 chunks +5 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev_unittest.cc View 5 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
xiyuan
3 years, 11 months ago (2017-01-25 19:43:43 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
df2217a1a4a5803474b51bd59a1f4ca11160c21d.

Powered by Google App Engine
This is Rietveld 408576698