Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 2657453003: [ash-md] Makes sure that minimized windows can be activated in overview (Closed)

Created:
3 years, 11 months ago by varkha
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[ash-md] Makes sure that minimized windows can be activated in overview When windows are minimized before entering overview mode, they are replaced with a widget that has mirrored layers. Opacity of the original window needs to be then set to 1 in order to make it visible (in WindowMirrorView::InitLayerOwner()). Upon exiting overview the original window's opacity is restored. This logic breaks if a window is selected - the opacity need not be restored (to zero). Make it so that the opacity is set to 1 upon exit if a window is selected. BUG=677177 Review-Url: https://codereview.chromium.org/2637403013 Cr-Commit-Position: refs/heads/master@{#445524} (cherry picked from commit 8f64e9220762c7c7d5237cb4b4222898c5b0f4dc) Review-Url: https://codereview.chromium.org/2657453003 . Cr-Commit-Position: refs/branch-heads/2987@{#47} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/e86ab7d65162a39b16e19710445f09e357c27a1e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -7 lines) Patch
M ash/common/wm/overview/scoped_transform_overview_window.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/common/wm/overview/scoped_transform_overview_window.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M ash/common/wm/overview/window_selector.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/common/wm/overview/window_selector.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/common/wm/overview/window_selector_item.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/common/wm/overview/window_selector_item.cc View 2 chunks +5 lines, -1 line 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
varkha
3 years, 11 months ago (2017-01-23 23:53:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e86ab7d65162a39b16e19710445f09e357c27a1e.

Powered by Google App Engine
This is Rietveld 408576698