Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2637403013: [ash-md] Makes sure that minimized windows can be activated in overview (Closed)

Created:
3 years, 11 months ago by varkha
Modified:
3 years, 11 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, Qiang(Joe) Xu
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ash-md] Makes sure that minimized windows can be activated in overview When windows are minimized before entering overview mode, they are replaced with a widget that has mirrored layers. Opacity of the original window needs to be then set to 1 in order to make it visible (in WindowMirrorView::InitLayerOwner()). Upon exiting overview the original window's opacity is restored. This logic breaks if a window is selected - the opacity need not be restored (to zero). Make it so that the opacity is set to 1 upon exit if a window is selected. BUG=677177 Review-Url: https://codereview.chromium.org/2637403013 Cr-Commit-Position: refs/heads/master@{#445524} Committed: https://chromium.googlesource.com/chromium/src/+/8f64e9220762c7c7d5237cb4b4222898c5b0f4dc

Patch Set 1 #

Patch Set 2 : [ash-md] Makes sure that minimized windows can be activated in overview #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -7 lines) Patch
M ash/common/wm/overview/scoped_transform_overview_window.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/common/wm/overview/scoped_transform_overview_window.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M ash/common/wm/overview/window_selector.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/common/wm/overview/window_selector.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ash/common/wm/overview/window_selector_item.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/common/wm/overview/window_selector_item.cc View 2 chunks +5 lines, -1 line 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
varkha
oshima@, can you please take a look? I think this got broken when mirrored layers ...
3 years, 11 months ago (2017-01-21 02:05:15 UTC) #4
oshima
lgtm thank you for the fix.
3 years, 11 months ago (2017-01-23 21:52:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2637403013/20001
3 years, 11 months ago (2017-01-23 21:56:57 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 22:48:19 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8f64e9220762c7c7d5237cb4b422...

Powered by Google App Engine
This is Rietveld 408576698