[wasm] Fix the --wasm_code_fuzzer_gen_test again.

[wasm] Fix the --wasm_code_fuzzer_gen_test again.

R=titzer@chromium.org, clemensh@chromium.org

Review-Url: https://codereview.chromium.org/2657443003
Cr-Commit-Position: refs/heads/master@{#42658}
Committed: https://chromium.googlesource.com/v8/v8/+/1c1742f38d457700ce11674104b4e352187c1b4c

[ahaas, 2017-01-24 15:27:45]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 15:27:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 15:35:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 15:35:02]

Dry run: Try jobs failed on following builders:
  v8_linux_chromium_gn_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)

[Clemens Hammacher, 2017-01-24 18:51:03]

https://codereview.chromium.org/2657443003/diff/1/src/wasm/function-body-deco...
File src/wasm/function-body-decoder.cc (right):

https://codereview.chromium.org/2657443003/diff/1/src/wasm/function-body-deco...
src/wasm/function-body-decoder.cc:1960: os << "k" <<
WasmOpcodes::OpcodeName(opcode) << ",";
Why is this outputting a "k" in front of the new opcode name? Is anyone actually
using this with for_debugging==false? If not, then just remove the boolean
parameter.

[ahaas, 2017-01-25 08:34:57]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 08:35:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 09:05:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 09:05:34]

Dry run: This issue passed the CQ dry run.

[titzer, 2017-01-25 10:31:07]

https://codereview.chromium.org/2657443003/diff/1/src/wasm/function-body-deco...
File src/wasm/function-body-decoder.cc (right):

https://codereview.chromium.org/2657443003/diff/1/src/wasm/function-body-deco...
src/wasm/function-body-decoder.cc:1887: const char*
OpcodeNameForDebugging(WasmOpcode opcode) {
RawOpcodeName?

https://codereview.chromium.org/2657443003/diff/1/src/wasm/function-body-deco...
src/wasm/function-body-decoder.cc:1900: bool PrintWasmCode(AccountingAllocator*
allocator, const FunctionBody& body,
I'd be OK with just renaming this method to PrintRawWasmCode and dropping the
boolean parameter.

https://codereview.chromium.org/2657443003/diff/1/src/wasm/function-body-deco...
src/wasm/function-body-decoder.cc:1960: os << "k" <<
WasmOpcodes::OpcodeName(opcode) << ",";
On 2017/01/24 18:51:02, Clemens Hammacher wrote:
> Why is this outputting a "k" in front of the new opcode name? Is anyone
actually
> using this with for_debugging==false? If not, then just remove the boolean
> parameter.

Right, the k shouldn't be necessary.

[ahaas, 2017-01-25 13:11:38]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 13:11:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2017-01-25 13:12:10]

PTAL

https://codereview.chromium.org/2657443003/diff/1/src/wasm/function-body-deco...
File src/wasm/function-body-decoder.cc (right):

https://codereview.chromium.org/2657443003/diff/1/src/wasm/function-body-deco...
src/wasm/function-body-decoder.cc:1887: const char*
OpcodeNameForDebugging(WasmOpcode opcode) {
On 2017/01/25 at 10:31:06, titzer wrote:
> RawOpcodeName?

Done.

https://codereview.chromium.org/2657443003/diff/1/src/wasm/function-body-deco...
src/wasm/function-body-decoder.cc:1900: bool PrintWasmCode(AccountingAllocator*
allocator, const FunctionBody& body,
On 2017/01/25 at 10:31:06, titzer wrote:
> I'd be OK with just renaming this method to PrintRawWasmCode and dropping the
boolean parameter.

Done.

https://codereview.chromium.org/2657443003/diff/1/src/wasm/function-body-deco...
src/wasm/function-body-decoder.cc:1960: os << "k" <<
WasmOpcodes::OpcodeName(opcode) << ",";
On 2017/01/25 at 10:31:06, titzer wrote:
> On 2017/01/24 18:51:02, Clemens Hammacher wrote:
> > Why is this outputting a "k" in front of the new opcode name? Is anyone
actually
> > using this with for_debugging==false? If not, then just remove the boolean
> > parameter.
> 
> Right, the k shouldn't be necessary.

As suggested I changed the output to
    os << RawOpcodeName(opcode) << ",";
now.

[Clemens Hammacher, 2017-01-25 13:16:45]

lgtm

[titzer, 2017-01-25 13:17:42]

lgtm with last naming suggestion

https://codereview.chromium.org/2657443003/diff/40001/src/wasm/function-body-...
File src/wasm/function-body-decoder.cc (right):

https://codereview.chromium.org/2657443003/diff/40001/src/wasm/function-body-...
src/wasm/function-body-decoder.cc:1882: void PrintWasmCodeForDebugging(const
byte* start, const byte* end) {
Can you also rename this method as well?

[ahaas, 2017-01-25 13:30:14]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 13:30:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2017-01-25 13:30:53]

On 2017/01/25 at 13:17:42, titzer wrote:
> lgtm with last naming suggestion
> 
>
https://codereview.chromium.org/2657443003/diff/40001/src/wasm/function-body-...
> File src/wasm/function-body-decoder.cc (right):
> 
>
https://codereview.chromium.org/2657443003/diff/40001/src/wasm/function-body-...
> src/wasm/function-body-decoder.cc:1882: void PrintWasmCodeForDebugging(const
byte* start, const byte* end) {
> Can you also rename this method as well?

Done.

[commit-bot: I haz the power, 2017-01-25 14:00:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 14:00:50]

Dry run: This issue passed the CQ dry run.

[ahaas, 2017-01-25 14:08:16]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2017-01-25 14:08:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
clemensh@chromium.org, titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2657443003/#ps60001
(title: "More renaming")

[commit-bot: I haz the power, 2017-01-25 14:08:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 14:10:08]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485353296181270,
"parent_rev": "bf782ec5124ff26d15a2bd413a4186ba20561e6d", "commit_rev":
"1c1742f38d457700ce11674104b4e352187c1b4c"}

[commit-bot: I haz the power, 2017-01-25 14:10:18]

Description was changed from

==========
[wasm] Fix the --wasm_code_fuzzer_gen_test again.

R=titzer@chromium.org, clemensh@chromium.org
==========

to

==========
[wasm] Fix the --wasm_code_fuzzer_gen_test again.

R=titzer@chromium.org, clemensh@chromium.org

Review-Url: https://codereview.chromium.org/2657443003
Cr-Commit-Position: refs/heads/master@{#42658}
Committed:
https://chromium.googlesource.com/v8/v8/+/1c1742f38d457700ce11674104b4e352187...
==========

[commit-bot: I haz the power, 2017-01-25 14:10:19]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/1c1742f38d457700ce11674104b4e352187...