Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2656563003: [wasm] Do the default int64-lowering for all non-i64 stores. (Closed)

Created:
3 years, 11 months ago by ahaas
Modified:
3 years, 11 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Do the default int64-lowering for all non-i64 stores. First issue I found with my local fuzzing. R=titzer@chromium.org BUG=v8:5884 Review-Url: https://codereview.chromium.org/2656563003 Cr-Commit-Position: refs/heads/master@{#42683} Committed: https://chromium.googlesource.com/v8/v8/+/a5e7382d846c620ceb62fdf02e8ee24794aa7775

Patch Set 1 #

Patch Set 2 : rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M src/compiler/int64-lowering.cc View 1 chunk +1 line, -3 lines 0 comments Download
A test/mjsunit/regress/wasm/regression-5884.js View 1 chunk +20 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (15 generated)
ahaas
3 years, 11 months ago (2017-01-24 18:37:42 UTC) #1
titzer
lgtm
3 years, 11 months ago (2017-01-25 10:31:58 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 2657443003 Patch 1). Please resolve the dependency and ...
3 years, 11 months ago (2017-01-25 10:33:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656563003/20001
3 years, 11 months ago (2017-01-25 16:34:57 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_compile_dbg on master.tryserver.v8 (JOB_TIMED_OUT, no build URL)
3 years, 11 months ago (2017-01-25 17:03:18 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656563003/20001
3 years, 11 months ago (2017-01-26 09:32:13 UTC) #19
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 09:38:17 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/a5e7382d846c620ceb62fdf02e8ee24794a...

Powered by Google App Engine
This is Rietveld 408576698