Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 2657143002: Revert of Replace homebrew scrollbar in Files app with that of Blink. (patchset #3 id:40001 of http… (Closed)

Created:
3 years, 10 months ago by yamaguchi
Modified:
3 years, 10 months ago
Reviewers:
fukino
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Revert of Replace homebrew scrollbar in Files app with that of Blink. (patchset #3 id:40001 of https://codereview.chromium.org/2554433002/ ) Reason for revert: Overlay scrollbar in Blink will be disabled on M57. https://bugs.chromium.org/p/chromium/issues/detail?id=307091#c124 Original issue's description: > Replace homebrew scrollbar in Files app with that of Blink. > > When overlay scrollbar is enabled in Chrome, there is animation to shrink and fade out the scrollbar thumb when inactive. However, scroll bars that aren't composited will not be animated > (see Issue 671644). It would make the scroll bar always thick and simply disappear without fading out after inactive. > As a workaround, this change makes the 2 boxes have solid background and contain:paint so as to make sure the scrollers are composited. > > BUG=666589 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/fa7b28294ab9ee7e07569054d4e65626e2535f4e > Cr-Commit-Position: refs/heads/master@{#436868} TBR=fukino@chromium.org BUG=666589, 684695 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2654873006 Cr-Commit-Position: refs/heads/master@{#446323} (cherry picked from commit 526e1938a4fef1e70e97295715b581d79a51574c) NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2657143002 Cr-Commit-Position: refs/branch-heads/2987@{#315} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/e50697019dd8e4092b07607e7cf9f3f4fbc8aef5

Patch Set 1 #

Messages

Total messages: 33 (24 generated)
yamaguchi
ptal
3 years, 10 months ago (2017-01-27 06:35:16 UTC) #5
fukino
lgtm
3 years, 10 months ago (2017-01-27 07:05:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657143002/1
3 years, 10 months ago (2017-01-27 07:06:08 UTC) #8
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 10 months ago (2017-01-27 07:06:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657143002/1
3 years, 10 months ago (2017-01-27 12:20:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657143002/1
3 years, 10 months ago (2017-02-06 02:06:04 UTC) #25
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 10 months ago (2017-02-06 02:06:07 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2657143002/1
3 years, 10 months ago (2017-02-06 02:34:19 UTC) #30
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 02:37:48 UTC) #33
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e50697019dd8e4092b07607e7cf9...

Powered by Google App Engine
This is Rietveld 408576698