Chromium Code Reviews
DescriptionRevert of Replace homebrew scrollbar in Files app with that of Blink. (patchset #3 id:40001 of https://codereview.chromium.org/2554433002/ )
Reason for revert:
Overlay scrollbar in Blink will be disabled on M57.
https://bugs.chromium.org/p/chromium/issues/detail?id=307091#c124
Original issue's description:
> Replace homebrew scrollbar in Files app with that of Blink.
>
> When overlay scrollbar is enabled in Chrome, there is animation to shrink and fade out the scrollbar thumb when inactive. However, scroll bars that aren't composited will not be animated
> (see Issue 671644). It would make the scroll bar always thick and simply disappear without fading out after inactive.
> As a workaround, this change makes the 2 boxes have solid background and contain:paint so as to make sure the scrollers are composited.
>
> BUG=666589
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/fa7b28294ab9ee7e07569054d4e65626e2535f4e
> Cr-Commit-Position: refs/heads/master@{#436868}
TBR=fukino@chromium.org
BUG=666589, 684695
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2654873006
Cr-Commit-Position: refs/heads/master@{#446323}
(cherry picked from commit 526e1938a4fef1e70e97295715b581d79a51574c)
NOTRY=true
NOPRESUBMIT=true
Review-Url: https://codereview.chromium.org/2657143002
Cr-Commit-Position: refs/branch-heads/2987@{#315}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/e50697019dd8e4092b07607e7cf9f3f4fbc8aef5
Patch Set 1 #Messages
Total messages: 33 (24 generated)
|