Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2654873006: Revert of Replace homebrew scrollbar in Files app with that of Blink. (Closed)

Created:
3 years, 11 months ago by yamaguchi
Modified:
3 years, 11 months ago
Reviewers:
bokan, fukino
CC:
chromium-reviews, yamaguchi+watch_chromium.org, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, jlklein+watch-closure_chromium.org, fukino+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org, bokan, flackr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Replace homebrew scrollbar in Files app with that of Blink. (patchset #3 id:40001 of https://codereview.chromium.org/2554433002/ ) Reason for revert: Overlay scrollbar in Blink will be disabled on M57. https://bugs.chromium.org/p/chromium/issues/detail?id=307091#c124 Original issue's description: > Replace homebrew scrollbar in Files app with that of Blink. > > When overlay scrollbar is enabled in Chrome, there is animation to shrink and fade out the scrollbar thumb when inactive. However, scroll bars that aren't composited will not be animated > (see Issue 671644). It would make the scroll bar always thick and simply disappear without fading out after inactive. > As a workaround, this change makes the 2 boxes have solid background and contain:paint so as to make sure the scrollers are composited. > > BUG=666589 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Committed: https://crrev.com/fa7b28294ab9ee7e07569054d4e65626e2535f4e > Cr-Commit-Position: refs/heads/master@{#436868} TBR=fukino@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=666589, 684695 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2654873006 Cr-Commit-Position: refs/heads/master@{#446323} Committed: https://chromium.googlesource.com/chromium/src/+/526e1938a4fef1e70e97295715b581d79a51574c

Patch Set 1 #

Patch Set 2 : Sync to head. #

Messages

Total messages: 19 (14 generated)
yamaguchi
Created Revert of Replace homebrew scrollbar in Files app with that of Blink.
3 years, 11 months ago (2017-01-26 09:14:14 UTC) #1
yamaguchi
ptal
3 years, 11 months ago (2017-01-26 09:24:08 UTC) #2
bokan
lgtm
3 years, 11 months ago (2017-01-26 14:28:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2654873006/170001
3 years, 11 months ago (2017-01-26 14:34:40 UTC) #16
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 14:40:01 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:170001) as
https://chromium.googlesource.com/chromium/src/+/526e1938a4fef1e70e97295715b5...

Powered by Google App Engine
This is Rietveld 408576698