Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2657093002:
Add NetworkQualityEstimator (NQE) UMA when ECT is computed (Closed)
DescriptionAdd NetworkQualityEstimator (NQE) UMA when ECT is computed
Add NetworkQualityEstimator (NQE) UMA when EffectiveConnectionType (ECT)
is computed. This new UMA is logged every time ECT is recomputed. This
ensures that the UMA will be logged for Cronet embedders too, and
reduces NQE's dependence on main frame flag.
BUG=687652
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
Review-Url: https://codereview.chromium.org/2657093002
Cr-Commit-Position: refs/heads/master@{#447566}
Committed: https://chromium.googlesource.com/chromium/src/+/7372751e9dcfb0479753f0019acded296873504d
Patch Set 1 #
Total comments: 2
Patch Set 2 : rkaplow comments #
Messages
Total messages: 30 (22 generated)
Description was changed from ========== Add NQE UMA BUG= ========== to ========== Add NetworkQualityEstimator (NQE) UMA when ECT is computed Add NetworkQualityEstimator (NQE) UMA when EffectiveConnectionType (ECT) is computed. This new UMA is logged in a way so that it will be logged for Cronet embedders too. BUG= ==========
Description was changed from ========== Add NetworkQualityEstimator (NQE) UMA when ECT is computed Add NetworkQualityEstimator (NQE) UMA when EffectiveConnectionType (ECT) is computed. This new UMA is logged in a way so that it will be logged for Cronet embedders too. BUG= ========== to ========== Add NetworkQualityEstimator (NQE) UMA when ECT is computed Add NetworkQualityEstimator (NQE) UMA when EffectiveConnectionType (ECT) is computed. This new UMA is logged in a way so that it will be logged for Cronet embedders too. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ==========
Description was changed from ========== Add NetworkQualityEstimator (NQE) UMA when ECT is computed Add NetworkQualityEstimator (NQE) UMA when EffectiveConnectionType (ECT) is computed. This new UMA is logged in a way so that it will be logged for Cronet embedders too. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ========== to ========== Add NetworkQualityEstimator (NQE) UMA when ECT is computed Add NetworkQualityEstimator (NQE) UMA when EffectiveConnectionType (ECT) is computed. This new UMA is logged every time ECT is recomputed. This ensures that the UMA will be logged for Cronet embedders too. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ==========
Description was changed from ========== Add NetworkQualityEstimator (NQE) UMA when ECT is computed Add NetworkQualityEstimator (NQE) UMA when EffectiveConnectionType (ECT) is computed. This new UMA is logged every time ECT is recomputed. This ensures that the UMA will be logged for Cronet embedders too. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ========== to ========== Add NetworkQualityEstimator (NQE) UMA when ECT is computed Add NetworkQualityEstimator (NQE) UMA when EffectiveConnectionType (ECT) is computed. This new UMA is logged every time ECT is recomputed. This ensures that the UMA will be logged for Cronet embedders too, and reduces NQE's dependence on main frame concept. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ==========
Description was changed from ========== Add NetworkQualityEstimator (NQE) UMA when ECT is computed Add NetworkQualityEstimator (NQE) UMA when EffectiveConnectionType (ECT) is computed. This new UMA is logged every time ECT is recomputed. This ensures that the UMA will be logged for Cronet embedders too, and reduces NQE's dependence on main frame concept. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ========== to ========== Add NetworkQualityEstimator (NQE) UMA when ECT is computed Add NetworkQualityEstimator (NQE) UMA when EffectiveConnectionType (ECT) is computed. This new UMA is logged every time ECT is recomputed. This ensures that the UMA will be logged for Cronet embedders too, and reduces NQE's dependence on main frame flag. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ==========
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
tbansal@chromium.org changed reviewers: + ryansturm@chromium.org
ryansturm: ptal. Thanks.
lgtm
tbansal@chromium.org changed reviewers: + rkaplow@chromium.org
rkaplow: ptal. Thanks.
lgtm https://codereview.chromium.org/2657093002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2657093002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:99373: - <int value="6" label="Broadband"/> i wouldn't delete it - just mark as obsolete.
The CQ bit was checked by tbansal@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tbansal@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ryansturm@chromium.org, rkaplow@chromium.org Link to the patchset: https://codereview.chromium.org/2657093002/#ps20001 (title: "rkaplow comments")
The CQ bit was unchecked by tbansal@chromium.org
Description was changed from ========== Add NetworkQualityEstimator (NQE) UMA when ECT is computed Add NetworkQualityEstimator (NQE) UMA when EffectiveConnectionType (ECT) is computed. This new UMA is logged every time ECT is recomputed. This ensures that the UMA will be logged for Cronet embedders too, and reduces NQE's dependence on main frame flag. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ========== to ========== Add NetworkQualityEstimator (NQE) UMA when ECT is computed Add NetworkQualityEstimator (NQE) UMA when EffectiveConnectionType (ECT) is computed. This new UMA is logged every time ECT is recomputed. This ensures that the UMA will be logged for Cronet embedders too, and reduces NQE's dependence on main frame flag. BUG=687652 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ==========
The CQ bit was checked by tbansal@chromium.org
https://codereview.chromium.org/2657093002/diff/1/tools/metrics/histograms/hi... File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/2657093002/diff/1/tools/metrics/histograms/hi... tools/metrics/histograms/histograms.xml:99373: - <int value="6" label="Broadband"/> On 2017/01/31 16:33:53, rkaplow wrote: > i wouldn't delete it - just mark as obsolete. Done.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485975049641920,
"parent_rev": "47a9403d16ca37b99175b07cea5ee41c574d36c5", "commit_rev":
"7372751e9dcfb0479753f0019acded296873504d"}
Message was sent while issue was closed.
Description was changed from ========== Add NetworkQualityEstimator (NQE) UMA when ECT is computed Add NetworkQualityEstimator (NQE) UMA when EffectiveConnectionType (ECT) is computed. This new UMA is logged every time ECT is recomputed. This ensures that the UMA will be logged for Cronet embedders too, and reduces NQE's dependence on main frame flag. BUG=687652 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester ========== to ========== Add NetworkQualityEstimator (NQE) UMA when ECT is computed Add NetworkQualityEstimator (NQE) UMA when EffectiveConnectionType (ECT) is computed. This new UMA is logged every time ECT is recomputed. This ensures that the UMA will be logged for Cronet embedders too, and reduces NQE's dependence on main frame flag. BUG=687652 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2657093002 Cr-Commit-Position: refs/heads/master@{#447566} Committed: https://chromium.googlesource.com/chromium/src/+/7372751e9dcfb0479753f0019acd... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/7372751e9dcfb0479753f0019acd... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
