Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: net/nqe/network_quality_estimator.cc

Issue 2657093002: Add NetworkQualityEstimator (NQE) UMA when ECT is computed (Closed)
Patch Set: rkaplow comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/nqe/network_quality_estimator_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/nqe/network_quality_estimator.cc
diff --git a/net/nqe/network_quality_estimator.cc b/net/nqe/network_quality_estimator.cc
index efc3ea9776448845432657a340d73d705be840b1..a232e18d84afe7da0e9281c01f017a2bf56ed7ba 100644
--- a/net/nqe/network_quality_estimator.cc
+++ b/net/nqe/network_quality_estimator.cc
@@ -1033,6 +1033,25 @@ void NetworkQualityEstimator::ComputeEffectiveConnectionType() {
network_quality_ = nqe::internal::NetworkQuality(http_rtt, transport_rtt,
downstream_throughput_kbps);
+ UMA_HISTOGRAM_ENUMERATION("NQE.EffectiveConnectionType.OnECTComputation",
+ effective_connection_type_,
+ EFFECTIVE_CONNECTION_TYPE_LAST);
+ if (network_quality_.http_rtt() != nqe::internal::InvalidRTT()) {
+ UMA_HISTOGRAM_TIMES("NQE.RTT.OnECTComputation",
+ network_quality_.http_rtt());
+ }
+
+ if (network_quality_.transport_rtt() != nqe::internal::InvalidRTT()) {
+ UMA_HISTOGRAM_TIMES("NQE.TransportRTT.OnECTComputation",
+ network_quality_.transport_rtt());
+ }
+
+ if (network_quality_.downstream_throughput_kbps() !=
+ nqe::internal::INVALID_RTT_THROUGHPUT) {
+ UMA_HISTOGRAM_COUNTS_1M("NQE.Kbps.OnECTComputation",
+ network_quality_.downstream_throughput_kbps());
+ }
+
NotifyObserversOfRTTOrThroughputComputed();
if (past_type != effective_connection_type_)
« no previous file with comments | « no previous file | net/nqe/network_quality_estimator_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698