Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2656983006: cc: Add image to rect map in DiscardableImageMap. (Closed)

Created:
3 years, 10 months ago by Khushal
Modified:
3 years, 10 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Add image to rect map in DiscardableImageMap. Cache the image to rect map for images captured by the metadata canvas in DiscardableImageMap. BUG=686267 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2656983006 Cr-Commit-Position: refs/heads/master@{#447626} Committed: https://chromium.googlesource.com/chromium/src/+/96b6d2af021de34460dc80aebb209615699ea995

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -3 lines) Patch
M cc/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/playback/discardable_image_map.h View 3 chunks +5 lines, -0 lines 0 comments Download
M cc/playback/discardable_image_map.cc View 5 chunks +14 lines, -3 lines 0 comments Download
M cc/playback/discardable_image_map_unittest.cc View 10 chunks +52 lines, -0 lines 0 comments Download
M cc/playback/display_item_list.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M cc/playback/display_item_list.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
A cc/playback/image_id.h View 1 chunk +14 lines, -0 lines 2 comments Download
M cc/playback/raster_source.h View 2 chunks +3 lines, -0 lines 0 comments Download
M cc/playback/raster_source.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (13 generated)
Khushal
3 years, 10 months ago (2017-01-28 00:04:19 UTC) #4
Khushal
On 2017/01/28 00:04:19, Khushal wrote: pingy!
3 years, 10 months ago (2017-02-01 00:17:40 UTC) #12
vmpstr
https://codereview.chromium.org/2656983006/diff/20001/cc/playback/image_id.h File cc/playback/image_id.h (right): https://codereview.chromium.org/2656983006/diff/20001/cc/playback/image_id.h#newcode1 cc/playback/image_id.h:1: // Copyright 2017 The Chromium Authors. All rights reserved. ...
3 years, 10 months ago (2017-02-01 01:16:45 UTC) #13
Khushal
https://codereview.chromium.org/2656983006/diff/20001/cc/playback/image_id.h File cc/playback/image_id.h (right): https://codereview.chromium.org/2656983006/diff/20001/cc/playback/image_id.h#newcode1 cc/playback/image_id.h:1: // Copyright 2017 The Chromium Authors. All rights reserved. ...
3 years, 10 months ago (2017-02-01 01:44:52 UTC) #14
vmpstr
lgtm, please keep a look for perf regressions since we've had those when we added ...
3 years, 10 months ago (2017-02-01 18:52:55 UTC) #15
Khushal
On 2017/02/01 18:52:55, vmpstr wrote: > lgtm, please keep a look for perf regressions since ...
3 years, 10 months ago (2017-02-01 20:59:14 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656983006/20001
3 years, 10 months ago (2017-02-01 20:59:45 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 22:48:53 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/96b6d2af021de34460dc80aebb20...

Powered by Google App Engine
This is Rietveld 408576698