cc: Add image to rect map in DiscardableImageMap.

cc: Add image to rect map in DiscardableImageMap.

Cache the image to rect map for images captured by the metadata canvas
in DiscardableImageMap.

BUG=686267
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2656983006
Cr-Commit-Position: refs/heads/master@{#447626}
Committed: https://chromium.googlesource.com/chromium/src/+/96b6d2af021de34460dc80aebb209615699ea995

[Khushal, 2017-01-28 00:03:52]

Description was changed from

==========
cc: Add image to rect map in DiscardableImageMap.

Cache the image to rect map for images captured by the metadata canvas
in DiscardableImageMap.

BUG=686267
==========

to

==========
cc: Add image to rect map in DiscardableImageMap.

Cache the image to rect map for images captured by the metadata canvas
in DiscardableImageMap.

BUG=686267
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Khushal, 2017-01-28 00:04:05]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[Khushal, 2017-01-28 00:04:18]

khushalsagar@chromium.org changed reviewers:
+ vmpstr@chromium.org

[commit-bot: I haz the power, 2017-01-28 00:05:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-28 00:07:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-28 00:07:45]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Khushal, 2017-01-28 00:17:48]

The CQ bit was checked by khushalsagar@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-28 00:18:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-28 01:45:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-28 01:45:37]

Dry run: This issue passed the CQ dry run.

[Khushal, 2017-02-01 00:17:40]

On 2017/01/28 00:04:19, Khushal wrote:

pingy!

[vmpstr, 2017-02-01 01:16:45]

https://codereview.chromium.org/2656983006/diff/20001/cc/playback/image_id.h
File cc/playback/image_id.h (right):

https://codereview.chromium.org/2656983006/diff/20001/cc/playback/image_id.h#...
cc/playback/image_id.h:1: // Copyright 2017 The Chromium Authors. All rights
reserved.
I don't know how I feel about a file just for a single typedef. 

Can we maybe tack this on in draw_image.h? (not as a part of DrawImage, but just
as a separate entry)

[Khushal, 2017-02-01 01:44:52]

https://codereview.chromium.org/2656983006/diff/20001/cc/playback/image_id.h
File cc/playback/image_id.h (right):

https://codereview.chromium.org/2656983006/diff/20001/cc/playback/image_id.h#...
cc/playback/image_id.h:1: // Copyright 2017 The Chromium Authors. All rights
reserved.
On 2017/02/01 01:16:45, vmpstr wrote:
> I don't know how I feel about a file just for a single typedef. 
> 
> Can we maybe tack this on in draw_image.h? (not as a part of DrawImage, but
just
> as a separate entry)

Hmmm, it doesn't have anything to do with DrawImage. Also I figured it was okay
since we have other stuff like this:
https://cs.chromium.org/chromium/src/cc/base/resource_id.h. We'll eventually end
up replacing this with something in cc/paint anyway.

[vmpstr, 2017-02-01 18:52:55]

lgtm, please keep a look for perf regressions since we've had those when we
added the region equivalent of this patch.

[Khushal, 2017-02-01 20:59:14]

On 2017/02/01 18:52:55, vmpstr wrote:
> lgtm, please keep a look for perf regressions since we've had those when we
> added the region equivalent of this patch.

Thanks. I ran the test that regressed the last time locally once.

[Khushal, 2017-02-01 20:59:24]

The CQ bit was checked by khushalsagar@chromium.org

[commit-bot: I haz the power, 2017-02-01 20:59:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 22:48:15]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485982764933300,
"parent_rev": "64dcf43897c11b5ddbfd849fe1145a74fe0b0b89", "commit_rev":
"96b6d2af021de34460dc80aebb209615699ea995"}

[commit-bot: I haz the power, 2017-02-01 22:48:52]

Description was changed from

==========
cc: Add image to rect map in DiscardableImageMap.

Cache the image to rect map for images captured by the metadata canvas
in DiscardableImageMap.

BUG=686267
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Add image to rect map in DiscardableImageMap.

Cache the image to rect map for images captured by the metadata canvas
in DiscardableImageMap.

BUG=686267
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2656983006
Cr-Commit-Position: refs/heads/master@{#447626}
Committed:
https://chromium.googlesource.com/chromium/src/+/96b6d2af021de34460dc80aebb20...
==========

[commit-bot: I haz the power, 2017-02-01 22:48:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/96b6d2af021de34460dc80aebb20...