Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2510)

Unified Diff: cc/playback/discardable_image_map.cc

Issue 2656983006: cc: Add image to rect map in DiscardableImageMap. (Closed)
Patch Set: rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/playback/discardable_image_map.cc
diff --git a/cc/playback/discardable_image_map.cc b/cc/playback/discardable_image_map.cc
index 29201d6fa87700085a6282553a7a16106845103c..7e1abd6640bd83f8173b65cc565260b55e9c0a52 100644
--- a/cc/playback/discardable_image_map.cc
+++ b/cc/playback/discardable_image_map.cc
@@ -62,9 +62,11 @@ class DiscardableImagesMetadataCanvas : public SkNWayCanvas {
DiscardableImagesMetadataCanvas(
int width,
int height,
- std::vector<std::pair<DrawImage, gfx::Rect>>* image_set)
+ std::vector<std::pair<DrawImage, gfx::Rect>>* image_set,
+ std::unordered_map<ImageId, gfx::Rect>* image_id_to_rect)
: SkNWayCanvas(width, height),
image_set_(image_set),
+ image_id_to_rect_(image_id_to_rect),
canvas_bounds_(SkRect::MakeIWH(width, height)),
canvas_size_(width, height) {}
@@ -198,9 +200,12 @@ class DiscardableImagesMetadataCanvas : public SkNWayCanvas {
SkIRect src_irect;
src_rect.roundOut(&src_irect);
+ gfx::Rect image_rect = SafeClampPaintRectToSize(paint_rect, canvas_size_);
+
+ (*image_id_to_rect_)[image->uniqueID()].Union(image_rect);
image_set_->push_back(std::make_pair(
DrawImage(std::move(image), src_irect, filter_quality, matrix),
- SafeClampPaintRectToSize(paint_rect, canvas_size_)));
+ image_rect));
}
// Currently this function only handles extracting images from SkImageShaders
@@ -224,6 +229,7 @@ class DiscardableImagesMetadataCanvas : public SkNWayCanvas {
}
std::vector<std::pair<DrawImage, gfx::Rect>>* image_set_;
+ std::unordered_map<ImageId, gfx::Rect>* image_id_to_rect_;
const SkRect canvas_bounds_;
const gfx::Size canvas_size_;
std::vector<SkPaint> saved_paints_;
@@ -239,7 +245,7 @@ std::unique_ptr<SkCanvas> DiscardableImageMap::BeginGeneratingMetadata(
const gfx::Size& bounds) {
DCHECK(all_images_.empty());
return base::MakeUnique<DiscardableImagesMetadataCanvas>(
- bounds.width(), bounds.height(), &all_images_);
+ bounds.width(), bounds.height(), &all_images_, &image_id_to_rect_);
}
void DiscardableImageMap::EndGeneratingMetadata() {
@@ -259,6 +265,11 @@ void DiscardableImageMap::GetDiscardableImagesInRect(
images->push_back(all_images_[index].first.ApplyScale(contents_scale));
}
+gfx::Rect DiscardableImageMap::GetRectForImage(ImageId image_id) const {
+ const auto& it = image_id_to_rect_.find(image_id);
+ return it == image_id_to_rect_.end() ? gfx::Rect() : it->second;
+}
+
DiscardableImageMap::ScopedMetadataGenerator::ScopedMetadataGenerator(
DiscardableImageMap* image_map,
const gfx::Size& bounds)

Powered by Google App Engine
This is Rietveld 408576698