Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2656833003: media: Reject promises and close sessions in MojoCdm destructor (Closed)

Created:
3 years, 11 months ago by xhwang
Modified:
3 years, 11 months ago
Reviewers:
jrummell
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

media: Reject promises and close sessions in MojoCdm destructor This was missed in the original CL at 0d5d318987dde8b. NOTRY=true NOPRESUBMIT=true TBR=jrummell@chromium.org BUG=671362, 682863 TEST=new test added Review-Url: https://codereview.chromium.org/2638403005 Cr-Commit-Position: refs/heads/master@{#445093} (cherry picked from commit fc12d84bae452abfef8e6e110908305ad5401a77) Review-Url: https://codereview.chromium.org/2656833003 Cr-Commit-Position: refs/branch-heads/2987@{#96} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/360a7fda6014a54cac1c40aed6548a52b90ae0ca

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -8 lines) Patch
M media/mojo/clients/mojo_cdm.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M media/mojo/clients/mojo_cdm_unittest.cc View 13 chunks +60 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656833003/1
3 years, 11 months ago (2017-01-25 21:39:17 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-25 21:39:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656833003/1
3 years, 11 months ago (2017-01-25 21:42:09 UTC) #8
commit-bot: I haz the power
CLs for remote refs other than refs/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
3 years, 11 months ago (2017-01-25 21:42:11 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656833003/1
3 years, 11 months ago (2017-01-25 21:48:08 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 21:50:21 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/360a7fda6014a54cac1c40aed654...

Powered by Google App Engine
This is Rietveld 408576698