Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2638403005: media: Reject promises and close sessions in MojoCdm destructor (Closed)

Created:
3 years, 11 months ago by xhwang
Modified:
3 years, 11 months ago
Reviewers:
jrummell
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, alokp+watch_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Reject promises and close sessions in MojoCdm destructor This was missed in the original CL at 0d5d318987dde8b. BUG=671362, 682863 TEST=new test added Review-Url: https://codereview.chromium.org/2638403005 Cr-Commit-Position: refs/heads/master@{#445093} Committed: https://chromium.googlesource.com/chromium/src/+/fc12d84bae452abfef8e6e110908305ad5401a77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -8 lines) Patch
M media/mojo/clients/mojo_cdm.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M media/mojo/clients/mojo_cdm_unittest.cc View 13 chunks +60 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
xhwang
PTAL
3 years, 11 months ago (2017-01-20 01:35:35 UTC) #2
jrummell
lgtm
3 years, 11 months ago (2017-01-20 18:08:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638403005/1
3 years, 11 months ago (2017-01-20 18:10:01 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 18:15:18 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fc12d84bae452abfef8e6e110908...

Powered by Google App Engine
This is Rietveld 408576698