Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 2656743003: [inspector] take into account inlined frames in ::HasNonBlackboxedFrameOnStack (Closed)

Created:
3 years, 11 months ago by kozy
Modified:
3 years, 11 months ago
Reviewers:
alph, dgozman, Yang
CC:
v8-reviews_googlegroups.com, Yang, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] take into account inlined frames in ::HasNonBlackboxedFrameOnStack BUG=v8:5842, chromium:583193 R=yangguo@chromium.org,dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2656743003 Cr-Commit-Position: refs/heads/master@{#42715} Committed: https://chromium.googlesource.com/v8/v8/+/adc42c3a822d53726fb114540ade6d62a8ab6971

Patch Set 1 #

Patch Set 2 : little fix in test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -4 lines) Patch
M src/api.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/debug/debug.h View 2 chunks +2 lines, -1 line 0 comments Download
M test/inspector/debugger/framework-break.js View 1 2 chunks +20 lines, -0 lines 0 comments Download
M test/inspector/debugger/framework-break-expected.txt View 1 1 chunk +9 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
kozy
please take a look!
3 years, 11 months ago (2017-01-25 20:39:50 UTC) #1
alph
lgtm
3 years, 11 months ago (2017-01-25 22:59:42 UTC) #2
Yang
lgtm
3 years, 11 months ago (2017-01-26 07:27:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656743003/20001
3 years, 11 months ago (2017-01-26 20:58:45 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 21:33:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/adc42c3a822d53726fb114540ade6d62a8a...

Powered by Google App Engine
This is Rietveld 408576698