[inspector] don't ignore uncaught exception if at least 1 frame isn't blackboxed

[inspector] don't ignore uncaught exception if at least 1 frame isn't blackboxed

- and fixed test.

BUG=v8:5842, chromium:583193
R=yangguo@chromium.org,dgozman@chromium.org,alph@chromium.org

Review-Url: https://codereview.chromium.org/2651683005
Cr-Commit-Position: refs/heads/master@{#42714}
Committed: https://chromium.googlesource.com/v8/v8/+/0ac7970a60f95948fb26cdf91130075eeee6dd74

[kozy, 2017-01-25 06:12:24]

another small blackboxing tuning, please take a look.

[Yang, 2017-01-25 10:10:16]

https://codereview.chromium.org/2651683005/diff/1/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/2651683005/diff/1/src/debug/debug.cc#newcode1754
src/debug/debug.cc:1754: bool is_top_frame_blackboxed =
IsBlackboxed(it.frame()->function()->shared());
This doesn't account for inlined frames. Please use
JavaScriptFrame::GetFunctions to get all shared function infos involved.

[kozy, 2017-01-25 17:38:50]

Patchset #2 (id:20001) has been deleted

[kozy, 2017-01-25 17:39:26]

all done.

https://codereview.chromium.org/2651683005/diff/1/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/2651683005/diff/1/src/debug/debug.cc#newcode1754
src/debug/debug.cc:1754: bool is_top_frame_blackboxed =
IsBlackboxed(it.frame()->function()->shared());
On 2017/01/25 10:10:15, Yang wrote:
> This doesn't account for inlined frames. Please use
> JavaScriptFrame::GetFunctions to get all shared function infos involved.

Done + added a test.

[dgozman, 2017-01-25 19:26:57]

tests lgtm :-)

[kozy, 2017-01-26 18:46:07]

Yang, please take a look! I need owner lgtm for debug.

[Yang, 2017-01-26 19:25:55]

lgtm thanks

[kozy, 2017-01-26 20:22:07]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2017-01-26 20:22:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-26 20:57:03]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485462127742790,
"parent_rev": "7be3b4c90f93405ae9875f2403341b5684fb4e14", "commit_rev":
"0ac7970a60f95948fb26cdf91130075eeee6dd74"}

[commit-bot: I haz the power, 2017-01-26 20:57:09]

Description was changed from

==========
[inspector] don't ignore uncaught exception if at least 1 frame isn't blackboxed

- and fixed test.

BUG=v8:5842, chromium:583193
R=yangguo@chromium.org,dgozman@chromium.org,alph@chromium.org
==========

to

==========
[inspector] don't ignore uncaught exception if at least 1 frame isn't blackboxed

- and fixed test.

BUG=v8:5842, chromium:583193
R=yangguo@chromium.org,dgozman@chromium.org,alph@chromium.org

Review-Url: https://codereview.chromium.org/2651683005
Cr-Commit-Position: refs/heads/master@{#42714}
Committed:
https://chromium.googlesource.com/v8/v8/+/0ac7970a60f95948fb26cdf91130075eeee...
==========

[commit-bot: I haz the power, 2017-01-26 20:57:09]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/0ac7970a60f95948fb26cdf91130075eeee...