|
|
Created:
3 years, 11 months ago by shend Modified:
3 years, 10 months ago CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, esprehn, rwlbuis Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMoved clear property to be generated in ComputedStyleBase.
Move the noninherited property clear and its enum, EClear,
to be generated in ComputedStyleBase. Also moved getter / setter /
initial value methods to be generated in ComputedStyleBase.
This also reduces the size of ComputedStyle by 8 bytes.
BUG=628043
Review-Url: https://codereview.chromium.org/2656733002
Cr-Commit-Position: refs/heads/master@{#447206}
Committed: https://chromium.googlesource.com/chromium/src/+/660b3866aba5c7195935ba0987ee3af9ea5a0649
Patch Set 1 #Patch Set 2 : Clear is not inherited #Patch Set 3 : Reduce ComputedStyle size #Patch Set 4 : Reduce ComputedStyle size #Patch Set 5 : Rebase #Patch Set 6 : Rebase #Patch Set 7 : Rebase #
Depends on Patchset: Messages
Total messages: 43 (36 generated)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
shend@chromium.org changed reviewers: + nainar@chromium.org
hi Naina, PTAL. Thanks
YEAH! \o/ LGTM
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by shend@chromium.org
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
shend@chromium.org changed reviewers: + sashab@chromium.org
Description was changed from ========== Moved clear property to be generated in ComputedStyleBase. Move the inherited property clear and its enum, EClear, to be generated in ComputedStyleBase. Also moved getter / setter / initial value methods to be generated in ComputedStyleBase. BUG=628043 ========== to ========== Moved clear property to be generated in ComputedStyleBase. Move the inherited property clear and its enum, EClear, to be generated in ComputedStyleBase. Also moved getter / setter / initial value methods to be generated in ComputedStyleBase. This also reduces the size of ComputedStyle by 8 bytes. BUG=628043 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Sasha PTAL :) Elliott, as discussed, this reduces the size of ComputedStyle by 8 bytes.
esprehn@chromium.org changed reviewers: + esprehn@chromium.org
lgtm
LGTM but you'll need to rebase onto CSSProperties.json5 :)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org, sashab@chromium.org, esprehn@chromium.org Link to the patchset: https://codereview.chromium.org/2656733002/#ps120001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 120001, "attempt_start_ts": 1485848653877560, "parent_rev": "27fc0832721cf08937ae13b403adf2f963fe9ebf", "commit_rev": "660b3866aba5c7195935ba0987ee3af9ea5a0649"}
Message was sent while issue was closed.
Description was changed from ========== Moved clear property to be generated in ComputedStyleBase. Move the inherited property clear and its enum, EClear, to be generated in ComputedStyleBase. Also moved getter / setter / initial value methods to be generated in ComputedStyleBase. This also reduces the size of ComputedStyle by 8 bytes. BUG=628043 ========== to ========== Moved clear property to be generated in ComputedStyleBase. Move the inherited property clear and its enum, EClear, to be generated in ComputedStyleBase. Also moved getter / setter / initial value methods to be generated in ComputedStyleBase. This also reduces the size of ComputedStyle by 8 bytes. BUG=628043 Review-Url: https://codereview.chromium.org/2656733002 Cr-Commit-Position: refs/heads/master@{#447206} Committed: https://chromium.googlesource.com/chromium/src/+/660b3866aba5c7195935ba0987ee... ==========
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as https://chromium.googlesource.com/chromium/src/+/660b3866aba5c7195935ba0987ee...
Message was sent while issue was closed.
Description was changed from ========== Moved clear property to be generated in ComputedStyleBase. Move the inherited property clear and its enum, EClear, to be generated in ComputedStyleBase. Also moved getter / setter / initial value methods to be generated in ComputedStyleBase. This also reduces the size of ComputedStyle by 8 bytes. BUG=628043 Review-Url: https://codereview.chromium.org/2656733002 Cr-Commit-Position: refs/heads/master@{#447206} Committed: https://chromium.googlesource.com/chromium/src/+/660b3866aba5c7195935ba0987ee... ========== to ========== Moved clear property to be generated in ComputedStyleBase. Move the noninherited property clear and its enum, EClear, to be generated in ComputedStyleBase. Also moved getter / setter / initial value methods to be generated in ComputedStyleBase. This also reduces the size of ComputedStyle by 8 bytes. BUG=628043 Review-Url: https://codereview.chromium.org/2656733002 Cr-Commit-Position: refs/heads/master@{#447206} Committed: https://chromium.googlesource.com/chromium/src/+/660b3866aba5c7195935ba0987ee... ========== |