Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2656733002: Moved clear property to be generated in ComputedStyleBase. (Closed)

Created:
3 years, 11 months ago by shend
Modified:
3 years, 10 months ago
Reviewers:
esprehn, nainar, sashab
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, esprehn, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moved clear property to be generated in ComputedStyleBase. Move the noninherited property clear and its enum, EClear, to be generated in ComputedStyleBase. Also moved getter / setter / initial value methods to be generated in ComputedStyleBase. This also reduces the size of ComputedStyle by 8 bytes. BUG=628043 Review-Url: https://codereview.chromium.org/2656733002 Cr-Commit-Position: refs/heads/master@{#447206} Committed: https://chromium.googlesource.com/chromium/src/+/660b3866aba5c7195935ba0987ee3af9ea5a0649

Patch Set 1 #

Patch Set 2 : Clear is not inherited #

Patch Set 3 : Reduce ComputedStyle size #

Patch Set 4 : Reduce ComputedStyle size #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -19 lines) Patch
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 2 3 4 5 6 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 3 4 5 6 4 chunks +1 line, -12 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 2 3 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 43 (36 generated)
shend
hi Naina, PTAL. Thanks
3 years, 11 months ago (2017-01-24 23:54:32 UTC) #6
nainar
YEAH! \o/ LGTM
3 years, 11 months ago (2017-01-24 23:56:31 UTC) #7
shend
Sasha PTAL :) Elliott, as discussed, this reduces the size of ComputedStyle by 8 bytes.
3 years, 11 months ago (2017-01-25 06:01:59 UTC) #29
esprehn
lgtm
3 years, 11 months ago (2017-01-25 06:33:31 UTC) #31
sashab
LGTM but you'll need to rebase onto CSSProperties.json5 :)
3 years, 10 months ago (2017-01-27 22:27:59 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656733002/120001
3 years, 10 months ago (2017-01-31 07:44:25 UTC) #39
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 07:49:45 UTC) #42
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/660b3866aba5c7195935ba0987ee...

Powered by Google App Engine
This is Rietveld 408576698