Changed EClear to an enum class and renamed its members

Changed EClear to an enum class and renamed its members

Changed EClear to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent, and added the 'k' prefix in line with the Blink rename to
match Chromium style.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to allow EClear to be used by generated
fields in ComputedStyleBase.

BUG=684966
Review-Url: https://codereview.chromium.org/2653123002
Cr-Commit-Position: refs/heads/master@{#447197}
Committed: https://chromium.googlesource.com/chromium/src/+/c5bebbb612832e8d1feee0f0cf972f41283496e0

[shend, 2017-01-24 23:23:07]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 23:24:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 23:24:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 23:24:07]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[shend, 2017-01-24 23:51:29]

shend@chromium.org changed reviewers:
+ bugsnash@chromium.org

[shend, 2017-01-24 23:53:50]

hi Bugs, PTAL. Thanks!

[Bugs Nash, 2017-01-25 01:17:34]

On 2017/01/24 at 23:53:50, shend wrote:
> hi Bugs, PTAL. Thanks!

lgtm, outstanding patch description well done :)

I think the whole enum class migration should have it's own bug that blocks the
clean up/generate ComputedStyle bug, since there is a lot of work to be done for
that sub-task.

[shend, 2017-01-25 01:50:56]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 01:51:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 01:51:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 01:51:49]

Dry run: No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[shend, 2017-01-25 03:00:45]

Description was changed from

==========
Changed EClear to an enum class and renamed its members

Changed EClear to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent, and added the 'k' prefix in line with the Blink rename to
match Chromium style.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to allow EClear to be used by generated
fields in ComputedStyleBase.

BUG=628043
==========

to

==========
Changed EClear to an enum class and renamed its members

Changed EClear to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent, and added the 'k' prefix in line with the Blink rename to
match Chromium style.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to allow EClear to be used by generated
fields in ComputedStyleBase.

BUG=684966
==========

[shend, 2017-01-25 03:44:47]

shend@chromium.org changed reviewers:
+ sashab@chromium.org

[shend, 2017-01-25 03:50:55]

Sasha PTAL. No trybot results since bugsnash@ doesn't seem to be a full
committer :(

[sashab, 2017-01-25 04:36:34]

LGTM no need for trybots, this either works or it doesnt :)

[sashab, 2017-01-25 04:36:52]

On 2017/01/25 at 04:36:34, sashab wrote:
> LGTM no need for trybots, this either works or it doesnt :)

Also +1 to bugs' suggestion that we should have a separate bug.

[shend, 2017-01-25 04:43:58]

On 2017/01/25 at 04:36:52, sashab wrote:
> On 2017/01/25 at 04:36:34, sashab wrote:
> > LGTM no need for trybots, this either works or it doesnt :)
> 
> Also +1 to bugs' suggestion that we should have a separate bug.


Yep, this CL now points to the new bug.

[shend, 2017-01-31 04:48:51]

The CQ bit was checked by shend@chromium.org

[shend, 2017-01-31 04:48:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
bugsnash@chromium.org, sashab@chromium.org
Link to the patchset: https://codereview.chromium.org/2653123002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-01-31 04:49:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 06:15:43]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485838131538410,
"parent_rev": "0dee95e08944e4ca548b5bf874d34a3695fc7a93", "commit_rev":
"c5bebbb612832e8d1feee0f0cf972f41283496e0"}

[commit-bot: I haz the power, 2017-01-31 06:17:08]

Description was changed from

==========
Changed EClear to an enum class and renamed its members

Changed EClear to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent, and added the 'k' prefix in line with the Blink rename to
match Chromium style.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to allow EClear to be used by generated
fields in ComputedStyleBase.

BUG=684966
==========

to

==========
Changed EClear to an enum class and renamed its members

Changed EClear to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent, and added the 'k' prefix in line with the Blink rename to
match Chromium style.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to allow EClear to be used by generated
fields in ComputedStyleBase.

BUG=684966

Review-Url: https://codereview.chromium.org/2653123002
Cr-Commit-Position: refs/heads/master@{#447197}
Committed:
https://chromium.googlesource.com/chromium/src/+/c5bebbb612832e8d1feee0f0cf97...
==========

[commit-bot: I haz the power, 2017-01-31 06:17:09]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/c5bebbb612832e8d1feee0f0cf97...