Moved isolate high watermark calculations into the Observatory client.

Moved isolate high watermark calculations into the Observatory client.

BUG=
R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/de72bf4991609c32f1025da1541ab5119097e8f8

[bkonyi, 2017-01-25 00:00:45]

bkonyi@google.com changed reviewers:
+ asiva@google.com, johnmccutchan@google.com, zra@google.com

[Cutch, 2017-01-25 00:04:46]

https://codereview.chromium.org/2656723002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/2656723002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/service/object.dart:1648: print("Threads:");
remove debug code

https://codereview.chromium.org/2656723002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/service/object.dart:1653: _memoryHighWatermark +=
threads[i].memoryHighWatermark;
This is different than the C code which sums the threads and then checks if it
is bigger than the pre-existing high water mark.

[bkonyi, 2017-01-25 00:27:13]

https://codereview.chromium.org/2656723002/diff/1/runtime/observatory/lib/src...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/2656723002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/service/object.dart:1648: print("Threads:");
On 2017/01/25 00:04:46, Cutch wrote:
> remove debug code

Done.

https://codereview.chromium.org/2656723002/diff/1/runtime/observatory/lib/src...
runtime/observatory/lib/src/service/object.dart:1653: _memoryHighWatermark +=
threads[i].memoryHighWatermark;
On 2017/01/25 00:04:46, Cutch wrote:
> This is different than the C code which sums the threads and then checks if it
> is bigger than the pre-existing high water mark.

Done.

[Cutch, 2017-01-25 21:22:33]

https://codereview.chromium.org/2656723002/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/2656723002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:1511: int _memoryHighWatermark;
initialize this to 0 here.

https://codereview.chromium.org/2656723002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:1653: if (_memoryHighWatermark
== null ||
please initialize _memoryHighWatermark to 0 and drop the null check.

[bkonyi, 2017-01-25 21:51:33]

https://codereview.chromium.org/2656723002/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/2656723002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:1511: int _memoryHighWatermark;
On 2017/01/25 21:22:33, Cutch wrote:
> initialize this to 0 here.

Done.

https://codereview.chromium.org/2656723002/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/service/object.dart:1653: if (_memoryHighWatermark
== null ||
On 2017/01/25 21:22:33, Cutch wrote:
> please initialize _memoryHighWatermark to 0 and drop the null check.

Done.

[Cutch, 2017-01-25 21:52:01]

lgtm

[bkonyi, 2017-01-25 23:03:48]

Description was changed from

==========
Moved isolate high watermark calculations into the Observatory client.

BUG=
==========

to

==========
Moved isolate high watermark calculations into the Observatory client.

BUG=
R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/de72bf4991609c32f1025da1541ab5119097e8f8
==========

[bkonyi, 2017-01-25 23:03:49]

Committed patchset #3 (id:40001) manually as
de72bf4991609c32f1025da1541ab5119097e8f8 (presubmit successful).