Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3210)

Unified Diff: runtime/vm/isolate.cc

Issue 2656723002: Moved isolate high watermark calculations into the Observatory client. (Closed)
Patch Set: Initialized _memoryHighWatermark in object.dart Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/isolate.h ('k') | runtime/vm/thread_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index b5a139be71e7a012a677d2f00039b1d4fe91fbe6..120b1d353b1a395d2187af6262db7c25bef58f9d 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -783,7 +783,6 @@ Isolate::Isolate(const Dart_IsolateFlags& api_flags)
single_step_(false),
thread_registry_(new ThreadRegistry()),
safepoint_handler_(new SafepointHandler(this)),
- memory_high_watermark_(0),
message_notify_callback_(NULL),
name_(NULL),
debugger_name_(NULL),
@@ -2118,7 +2117,6 @@ void Isolate::PrintJSON(JSONStream* stream, bool ref) {
}
}
- jsobj.AddPropertyF("_memoryHighWatermark", "%" Pu "", memory_high_watermark_);
jsobj.AddProperty("_threads", thread_registry_);
}
#endif
@@ -2717,7 +2715,6 @@ void Isolate::UnscheduleThread(Thread* thread,
// Ensure that the thread reports itself as being at a safepoint.
thread->EnterSafepoint();
}
- UpdateMemoryHighWatermark();
OSThread* os_thread = thread->os_thread();
ASSERT(os_thread != NULL);
os_thread->DisableThreadInterrupts();
@@ -2738,15 +2735,6 @@ void Isolate::UnscheduleThread(Thread* thread,
}
-void Isolate::UpdateMemoryHighWatermark() {
- const uintptr_t thread_watermarks_total =
- thread_registry()->ThreadHighWatermarksTotalLocked();
- if (thread_watermarks_total > memory_high_watermark_) {
- memory_high_watermark_ = thread_watermarks_total;
- }
-}
-
-
static RawInstance* DeserializeObject(Thread* thread,
uint8_t* obj_data,
intptr_t obj_len) {
« no previous file with comments | « runtime/vm/isolate.h ('k') | runtime/vm/thread_registry.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698