Moved isolate high watermark calculations into the Observatory client.

runtime/observatory/lib/src/service/object.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of service;
 
 // Some value smaller than the object ring, so requesting a large array
 // doesn't result in an expired ref because the elements lapped it in the
 // object ring.
 const int kDefaultFieldLimit = 100;
@@ skipping 1627 matching lines @@
     extensionRPCs.clear();
     if (map['extensionRPCs'] != null) {
       extensionRPCs.addAll(map['extensionRPCs']);
     }
 
     threads.clear();
     if(map['_threads'] != null) {
       threads.addAll(map['_threads']);
     }
 
-    _memoryHighWatermark = int.parse(map['_memoryHighWatermark']);
+    print("Threads:");

[Cutch, 2017/01/25 00:04:46]

remove debug code

[bkonyi, 2017/01/25 00:27:13]

Done.

+    print(map['_threads']);
 
-    if (map['threads'] != null) {
-      threads.addAll(map['threads']);
+    _memoryHighWatermark = 0;
+    for (var i = 0; i < threads.length; i++) {
+      _memoryHighWatermark += threads[i].memoryHighWatermark;

[Cutch, 2017/01/25 00:04:46]

This is different than the C code which sums the threads and then checks if it
is bigger than the pre-existing high water mark.

[bkonyi, 2017/01/25 00:27:13]

Done.

     }
 
     _numZoneHandles = map['_numZoneHandles'];
     _numScopedHandles = map['_numScopedHandles'];
   }
 
   Future<TagProfile> updateTagProfile() {
     return isolate.invokeRpcNoUpgrade('_getTagProfile', {}).then((Map map) {
       var seconds = new DateTime.now().millisecondsSinceEpoch / 1000.0;
       tagProfile._processTagProfile(seconds, map);
@@ skipping 2852 matching lines @@
     var v = list[i];
     if ((v is Map) && _isServiceMap(v)) {
       list[i] = owner.getFromMap(v);
     } else if (v is List) {
       _upgradeList(v, owner);
     } else if (v is Map) {
       _upgradeMap(v, owner);
     }
   }
 }