Issue 2656713009: Merged to M57.

Issue 2656713009: Merged to M57. (Closed)

Created:
3 years, 10 months ago by Sorin Jianu

Modified:
3 years, 10 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

Merged to M57. Include build/build_config.h in all component updater files. All files using conditional compilation must include the build_config, otherwise the platform symbols are not defined. BUG=684950 Review-Url: https://codereview.chromium.org/2655813002 Cr-Commit-Position: refs/heads/master@{#446050} (cherry picked from commit 96d71e0c6c152a39ee9b452c96428af7cc4520bc) Review-Url: https://codereview.chromium.org/2656713009 . Cr-Commit-Position: refs/branch-heads/2987@{#148} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/02cb3e5d0fddfbe903e2a4dd8f8f010d516f8b89

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -6 lines)			Patch
M	chrome/browser/component_updater/chrome_component_updater_configurator.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/component_updater/component_updater_utils.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	components/update_client/update_checker_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	components/update_client/updater_state.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	components/update_client/updater_state_unittest.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

Sorin Jianu

3 years, 10 months ago (2017-01-27 17:06:46 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
02cb3e5d0fddfbe903e2a4dd8f8f010d516f8b89.