Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2656693007: [LayoutNG] Return MinAndMaxContentSizes by value, step 1 (Closed)

Created:
3 years, 11 months ago by dgrogan
Modified:
3 years, 10 months ago
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[LayoutNG] Return MinAndMaxContentSizes by value, step 1 It's small enough that we probably don't need to worry about copying it. ComputeMinAndMaxContentSizesSync was a small convenience wrapper that did this; we don't need it anymore. Step 2 will tackle NGBlockLayoutAlgorithm::ComputeMinAndMaxContentSizes BUG=635619 Review-Url: https://codereview.chromium.org/2656693007 Cr-Commit-Position: refs/heads/master@{#446421} Committed: https://chromium.googlesource.com/chromium/src/+/2f09779466558e6e2ce51f9fa74ec00c10cdc8c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -34 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.h View 1 chunk +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.cc View 4 chunks +15 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_out_of_flow_layout_part.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
dgrogan
ptal?
3 years, 11 months ago (2017-01-25 23:31:39 UTC) #2
Gleb Lanbin
lgtm
3 years, 11 months ago (2017-01-25 23:49:28 UTC) #3
ikilpatrick
lgtm
3 years, 11 months ago (2017-01-26 04:39:10 UTC) #5
ikilpatrick
thanks :)
3 years, 11 months ago (2017-01-26 04:39:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656693007/1
3 years, 11 months ago (2017-01-26 16:53:07 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/2f09779466558e6e2ce51f9fa74ec00c10cdc8c6
3 years, 11 months ago (2017-01-26 20:11:35 UTC) #11
cbiesinger
3 years, 10 months ago (2017-01-31 01:04:44 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698