third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc - Issue 2656693007: [LayoutNG] Return MinAndMaxContentSizes by value, step 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc

Issue 2656693007: [LayoutNG] Return MinAndMaxContentSizes by value, step 1 (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc

index 6c1822d454f8ae08e636bcf83f10e45a5da469d5..656723f22b6f477156d9c01f5b1bfa275a64b93c 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_node_test.cc

@@ -27,9 +27,7 @@ TEST_F(NGBlockNodeForTest, MinAndMaxContent) {

NGBlockNode* box = new NGBlockNode(style_.get());

box->SetFirstChild(first_child);

- MinAndMaxContentSizes sizes;

- while (!box->ComputeMinAndMaxContentSizes(&sizes))

- continue;

+ MinAndMaxContentSizes sizes = box->ComputeMinAndMaxContentSizes();

EXPECT_EQ(LayoutUnit(kWidth), sizes.min_content);

EXPECT_EQ(LayoutUnit(kWidth), sizes.max_content);

}