V8 Inspector: remove V8ConsoleAPIType from the API, reuse v8::Isolate::MessageErrorLevel instead.

V8 Inspector: remove V8ConsoleAPIType from the API, reuse v8::Isolate::MessageErrorLevel instead.

BUG=chromium:682521
Review-Url: https://codereview.chromium.org/2656613004
Cr-Commit-Position: refs/heads/master@{#42666}
Committed: https://chromium.googlesource.com/v8/v8/+/76e31da4f668dbd962456e21634c14d6a12ba37c

[pfeldman, 2017-01-24 20:12:00]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[pfeldman, 2017-01-24 20:13:49]

pfeldman@chromium.org changed reviewers:
+ alph@chromium.org

[pfeldman, 2017-01-24 20:20:00]

Description was changed from

==========
V8 Inspector: remove V8ConsoleAPIType from the API, reuse
v8::Isolate::MessageErrorLevel instead.

BUG=682521
==========

to

==========
V8 Inspector: remove V8ConsoleAPIType from the API, reuse
v8::Isolate::MessageErrorLevel instead.

BUG=chromium:682521
==========

[dgozman, 2017-01-24 23:07:23]

lgtm

https://codereview.chromium.org/2656613004/diff/40001/src/inspector/v8-consol...
File src/inspector/v8-console-message.cc (right):

https://codereview.chromium.org/2656613004/diff/40001/src/inspector/v8-consol...
src/inspector/v8-console-message.cc:393: clientType = V8ConsoleAPIType::kInfo;
You are now reporting kInfo for console.log. That's fine if no tests break
though.

[pfeldman, 2017-01-24 23:15:02]

On 2017/01/24 23:07:23, dgozman wrote:
> lgtm
> 
>
https://codereview.chromium.org/2656613004/diff/40001/src/inspector/v8-consol...
> File src/inspector/v8-console-message.cc (right):
> 
>
https://codereview.chromium.org/2656613004/diff/40001/src/inspector/v8-consol...
> src/inspector/v8-console-message.cc:393: clientType = V8ConsoleAPIType::kInfo;
> You are now reporting kInfo for console.log. That's fine if no tests break
> though.

Yes, that is intentional, Log level no longer exists in the embedder.

[dgozman, 2017-01-25 00:01:32]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2017-01-25 00:01:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 00:05:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 00:05:15]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/33251)

[pfeldman, 2017-01-25 00:07:33]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 00:07:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 00:24:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 00:24:53]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[pfeldman, 2017-01-25 21:26:05]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 21:26:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 21:59:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 21:59:40]

Dry run: This issue passed the CQ dry run.

[alph, 2017-01-25 22:21:29]

The CQ bit was checked by alph@chromium.org

[alph, 2017-01-25 22:21:29]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2656613004/#ps80001
(title: "rebaselined the test")

[commit-bot: I haz the power, 2017-01-25 22:21:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 22:23:21]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1485382889220760,
"parent_rev": "64b9aec06c22ee375dca6cacc8760514e4c02a07", "commit_rev":
"76e31da4f668dbd962456e21634c14d6a12ba37c"}

[commit-bot: I haz the power, 2017-01-25 22:23:26]

Description was changed from

==========
V8 Inspector: remove V8ConsoleAPIType from the API, reuse
v8::Isolate::MessageErrorLevel instead.

BUG=chromium:682521
==========

to

==========
V8 Inspector: remove V8ConsoleAPIType from the API, reuse
v8::Isolate::MessageErrorLevel instead.

BUG=chromium:682521

Review-Url: https://codereview.chromium.org/2656613004
Cr-Commit-Position: refs/heads/master@{#42666}
Committed:
https://chromium.googlesource.com/v8/v8/+/76e31da4f668dbd962456e21634c14d6a12...
==========

[commit-bot: I haz the power, 2017-01-25 22:23:26]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/76e31da4f668dbd962456e21634c14d6a12...