Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Side by Side Diff: include/v8-inspector.h

Issue 2656613004: V8 Inspector: remove V8ConsoleAPIType from the API, reuse v8::Isolate::MessageErrorLevel instead. (Closed)
Patch Set: rebaselined the test Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/inspector/js_protocol.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_V8_INSPECTOR_H_ 5 #ifndef V8_V8_INSPECTOR_H_
6 #define V8_V8_INSPECTOR_H_ 6 #define V8_V8_INSPECTOR_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <cctype> 9 #include <cctype>
10 10
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 182
183 virtual v8::Local<v8::Context> ensureDefaultContextInGroup( 183 virtual v8::Local<v8::Context> ensureDefaultContextInGroup(
184 int contextGroupId) { 184 int contextGroupId) {
185 return v8::Local<v8::Context>(); 185 return v8::Local<v8::Context>();
186 } 186 }
187 virtual void beginEnsureAllContextsInGroup(int contextGroupId) {} 187 virtual void beginEnsureAllContextsInGroup(int contextGroupId) {}
188 virtual void endEnsureAllContextsInGroup(int contextGroupId) {} 188 virtual void endEnsureAllContextsInGroup(int contextGroupId) {}
189 189
190 virtual void installAdditionalCommandLineAPI(v8::Local<v8::Context>, 190 virtual void installAdditionalCommandLineAPI(v8::Local<v8::Context>,
191 v8::Local<v8::Object>) {} 191 v8::Local<v8::Object>) {}
192 // Deprecated, to be replaced with v8::Isolate::MessageErrorLevel version.
192 virtual void consoleAPIMessage(int contextGroupId, V8ConsoleAPIType, 193 virtual void consoleAPIMessage(int contextGroupId, V8ConsoleAPIType,
193 const StringView& message, 194 const StringView& message,
194 const StringView& url, unsigned lineNumber, 195 const StringView& url, unsigned lineNumber,
195 unsigned columnNumber, V8StackTrace*) {} 196 unsigned columnNumber, V8StackTrace*) {}
197 virtual void consoleAPIMessage(int contextGroupId,
198 v8::Isolate::MessageErrorLevel level,
199 const StringView& message,
200 const StringView& url, unsigned lineNumber,
201 unsigned columnNumber, V8StackTrace*) {}
196 virtual v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*, 202 virtual v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*,
197 v8::Local<v8::Context>) { 203 v8::Local<v8::Context>) {
198 return v8::MaybeLocal<v8::Value>(); 204 return v8::MaybeLocal<v8::Value>();
199 } 205 }
200 206
201 virtual void consoleTime(const StringView& title) {} 207 virtual void consoleTime(const StringView& title) {}
202 virtual void consoleTimeEnd(const StringView& title) {} 208 virtual void consoleTimeEnd(const StringView& title) {}
203 virtual void consoleTimeStamp(const StringView& title) {} 209 virtual void consoleTimeStamp(const StringView& title) {}
210 virtual void consoleClear(int contextGroupId) {}
204 virtual double currentTimeMS() { return 0; } 211 virtual double currentTimeMS() { return 0; }
205 typedef void (*TimerCallback)(void*); 212 typedef void (*TimerCallback)(void*);
206 virtual void startRepeatingTimer(double, TimerCallback, void* data) {} 213 virtual void startRepeatingTimer(double, TimerCallback, void* data) {}
207 virtual void cancelTimer(void* data) {} 214 virtual void cancelTimer(void* data) {}
208 215
209 // TODO(dgozman): this was added to support service worker shadow page. We 216 // TODO(dgozman): this was added to support service worker shadow page. We
210 // should not connect at all. 217 // should not connect at all.
211 virtual bool canExecuteScripts(int contextGroupId) { return true; } 218 virtual bool canExecuteScripts(int contextGroupId) { return true; }
212 }; 219 };
213 220
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
258 265
259 // API methods. 266 // API methods.
260 virtual std::unique_ptr<V8StackTrace> createStackTrace( 267 virtual std::unique_ptr<V8StackTrace> createStackTrace(
261 v8::Local<v8::StackTrace>) = 0; 268 v8::Local<v8::StackTrace>) = 0;
262 virtual std::unique_ptr<V8StackTrace> captureStackTrace(bool fullStack) = 0; 269 virtual std::unique_ptr<V8StackTrace> captureStackTrace(bool fullStack) = 0;
263 }; 270 };
264 271
265 } // namespace v8_inspector 272 } // namespace v8_inspector
266 273
267 #endif // V8_V8_INSPECTOR_H_ 274 #endif // V8_V8_INSPECTOR_H_
OLDNEW
« no previous file with comments | « no previous file | src/inspector/js_protocol.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698