Remove unused typemap includes from generated C++ mojo bindings.

Remove unused typemap includes from generated C++ mojo bindings.

This restricts additional headers from typemaps to only types that are
used within the mojom.

BUG=652404
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2656583002
Cr-Commit-Position: refs/heads/master@{#448740}
Committed: https://chromium.googlesource.com/chromium/src/+/406822fa3d00ff5aeb7afa2099abff3d2672d3c9

[Sam McNally, 2017-01-24 11:13:29]

Description was changed from

==========
Filter typemap headers to types that are used.

BUG=652404
==========

to

==========
Filter typemap headers to types that are used.

BUG=652404
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Sam McNally, 2017-01-24 11:13:34]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 11:13:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 11:19:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 11:19:39]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Sam McNally, 2017-01-24 11:41:10]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 11:41:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 11:48:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 11:48:20]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Sam McNally, 2017-01-25 01:09:31]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 01:10:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 01:22:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 01:22:50]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Sam McNally, 2017-01-25 04:34:54]

Description was changed from

==========
Filter typemap headers to types that are used.

BUG=652404
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove some unused includes from generated C++ mojo bindings.

This restricts additional headers from typemaps to only types that are
used within the mojom. It also removes some unnecessary standard
bindings headers, e.g. <unordered_map> when a mojom contains no maps.

BUG=652404
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Sam McNally, 2017-01-25 04:55:54]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 04:56:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2017-01-25 04:59:04]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 04:59:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 05:14:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 05:14:57]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Sam McNally, 2017-01-25 05:36:13]

Description was changed from

==========
Remove some unused includes from generated C++ mojo bindings.

This restricts additional headers from typemaps to only types that are
used within the mojom. It also removes some unnecessary standard
bindings headers, e.g. <unordered_map> when a mojom contains no maps.

BUG=652404
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove some unused includes from generated C++ mojo bindings.

This restricts additional headers from typemaps to only types that are
used within the mojom. It also removes some unnecessary standard
bindings headers, e.g. <unordered_map> when a mojom contains no maps.

BUG=652404
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Sam McNally, 2017-01-25 05:54:25]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-25 05:54:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-25 06:33:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-25 06:33:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sam McNally, 2017-01-29 22:42:35]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-29 22:42:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-29 22:56:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-29 22:56:35]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Sam McNally, 2017-01-31 01:34:26]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 01:34:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 01:37:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 01:37:30]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Sam McNally, 2017-01-31 17:40:12]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 17:40:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 17:57:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 17:57:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sam McNally, 2017-01-31 18:02:14]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 18:02:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2017-01-31 20:00:59]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 20:01:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-31 20:26:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-31 20:26:44]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Sam McNally, 2017-01-31 22:53:55]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-31 22:54:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 01:41:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 01:41:56]

Dry run: Try jobs failed on following builders:
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)

[Sam McNally, 2017-02-01 18:00:32]

sammc@chromium.org changed reviewers:
+ rockot@chromium.org, yzshen@chromium.org

[yzshen1, 2017-02-01 20:25:59]

https://codereview.chromium.org/2656583002/diff/220001/mojo/public/tools/bind...
File mojo/public/tools/bindings/generators/mojom_cpp_generator.py (right):

https://codereview.chromium.org/2656583002/diff/220001/mojo/public/tools/bind...
mojo/public/tools/bindings/generators/mojom_cpp_generator.py:112: def
NamespaceToArray(namespace):
Could we remove this one? (There is one in generator.py now)

https://codereview.chromium.org/2656583002/diff/220001/mojo/public/tools/bind...
File mojo/public/tools/bindings/pylib/mojom/generate/generator.py (right):

https://codereview.chromium.org/2656583002/diff/220001/mojo/public/tools/bind...
mojo/public/tools/bindings/pylib/mojom/generate/generator.py:34: if f.read() ==
contents:
Why do we need this check? It seems to be a fairly expensive check. Do we try to
re-write up-to-date files frequently?

https://codereview.chromium.org/2656583002/diff/220001/mojo/public/tools/bind...
mojo/public/tools/bindings/pylib/mojom/generate/generator.py:55: def
Format(self, separator, prefixed=False,
Could you please explain why we need to introduce NameFormatter in generator.py?
IIUC, it is only used in mojom_cpp_generator.py, and its subclass has slightly
different Format() implementation, which seems confusing.

[Sam McNally, 2017-02-02 19:24:24]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 19:24:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 19:26:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 19:26:54]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[Sam McNally, 2017-02-02 21:08:58]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 21:09:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2017-02-02 22:01:46]

https://codereview.chromium.org/2656583002/diff/220001/mojo/public/tools/bind...
File mojo/public/tools/bindings/generators/mojom_cpp_generator.py (right):

https://codereview.chromium.org/2656583002/diff/220001/mojo/public/tools/bind...
mojo/public/tools/bindings/generators/mojom_cpp_generator.py:112: def
NamespaceToArray(namespace):
On 2017/02/01 20:25:57, yzshen1 wrote:
> Could we remove this one? (There is one in generator.py now)

Removed the one in generator.py instead since I'm no longer adding anything that
uses it there.

https://codereview.chromium.org/2656583002/diff/220001/mojo/public/tools/bind...
File mojo/public/tools/bindings/pylib/mojom/generate/generator.py (right):

https://codereview.chromium.org/2656583002/diff/220001/mojo/public/tools/bind...
mojo/public/tools/bindings/pylib/mojom/generate/generator.py:34: if f.read() ==
contents:
On 2017/02/01 20:25:57, yzshen1 wrote:
> Why do we need this check? It seems to be a fairly expensive check. Do we try
to
> re-write up-to-date files frequently?

Only when changing the bindings generator.

https://codereview.chromium.org/2656583002/diff/220001/mojo/public/tools/bind...
mojo/public/tools/bindings/pylib/mojom/generate/generator.py:55: def
Format(self, separator, prefixed=False,
On 2017/02/01 20:25:57, yzshen1 wrote:
> Could you please explain why we need to introduce NameFormatter in
generator.py?
> IIUC, it is only used in mojom_cpp_generator.py, and its subclass has slightly
> different Format() implementation, which seems confusing.

This was a leftover from a previous approach. Removed.

[yzshen1, 2017-02-02 22:33:58]

https://codereview.chromium.org/2656583002/diff/260001/mojo/public/tools/bind...
File mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl (right):

https://codereview.chromium.org/2656583002/diff/260001/mojo/public/tools/bind...
mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl:46: {%- for
import in imports %}
I am not quite sure about the criteria what includes should be specified here
and what should be in the .py file. For example, does it make sense to move this
for-block of includes into |public_headers| as well? Or even moving all includes
there?

https://codereview.chromium.org/2656583002/diff/260001/mojo/public/tools/bind...
File mojo/public/tools/bindings/generators/mojom_cpp_generator.py (right):

https://codereview.chromium.org/2656583002/diff/260001/mojo/public/tools/bind...
mojo/public/tools/bindings/generators/mojom_cpp_generator.py:542: "array":
["<vector>"],
(Not saying that I have a strong preference, just curious) Does it cost much if
we always include these headers, and only selectively include those files for
typemapping?

[commit-bot: I haz the power, 2017-02-02 23:43:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 23:43:33]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[yzshen1, 2017-02-03 00:31:45]

https://codereview.chromium.org/2656583002/diff/260001/mojo/public/tools/bind...
File mojo/public/tools/bindings/generators/mojom_cpp_generator.py (right):

https://codereview.chromium.org/2656583002/diff/260001/mojo/public/tools/bind...
mojo/public/tools/bindings/generators/mojom_cpp_generator.py:190: not
_current_typemap[ GetFullMojomNameForKind(kind)]["hashable"]):
nit: the empty space is not needed.

https://codereview.chromium.org/2656583002/diff/260001/mojo/public/tools/bind...
mojo/public/tools/bindings/generators/mojom_cpp_generator.py:194: return not
(IsTypemappedKind(kind) and not _current_typemap[
It seems a little easier to read with
"return not XXX or YYY"

https://codereview.chromium.org/2656583002/diff/260001/mojo/public/tools/bind...
mojo/public/tools/bindings/generators/mojom_cpp_generator.py:700: for kind in
self.module.structs + self.module.unions:
We should also consider enum typemapping, right? Enums could be standalone,
inside structs, insides interfaces.

[Sam McNally, 2017-02-03 02:14:23]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 02:15:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2017-02-03 02:27:50]

Patchset #15 (id:280001) has been deleted

[Sam McNally, 2017-02-03 02:28:32]

https://codereview.chromium.org/2656583002/diff/260001/mojo/public/tools/bind...
File mojo/public/tools/bindings/generators/mojom_cpp_generator.py (right):

https://codereview.chromium.org/2656583002/diff/260001/mojo/public/tools/bind...
mojo/public/tools/bindings/generators/mojom_cpp_generator.py:190: not
_current_typemap[ GetFullMojomNameForKind(kind)]["hashable"]):
On 2017/02/03 00:31:45, yzshen1 wrote:
> nit: the empty space is not needed.

Done.

https://codereview.chromium.org/2656583002/diff/260001/mojo/public/tools/bind...
mojo/public/tools/bindings/generators/mojom_cpp_generator.py:194: return not
(IsTypemappedKind(kind) and not _current_typemap[
On 2017/02/03 00:31:45, yzshen1 wrote:
> It seems a little easier to read with
> "return not XXX or YYY"

Done.

https://codereview.chromium.org/2656583002/diff/260001/mojo/public/tools/bind...
mojo/public/tools/bindings/generators/mojom_cpp_generator.py:542: "array":
["<vector>"],
On 2017/02/02 22:33:58, yzshen1 wrote:
> (Not saying that I have a strong preference, just curious) Does it cost much
if
> we always include these headers, and only selectively include those files for
> typemapping?

Perf-wise, probably not too much. Including a .mojom.h file does pull in a lot
of other headers though, which makes IWYU harder. That's probably a lost cause
until modules solve everything.

I'll split it out from this CL at least.

https://codereview.chromium.org/2656583002/diff/260001/mojo/public/tools/bind...
mojo/public/tools/bindings/generators/mojom_cpp_generator.py:700: for kind in
self.module.structs + self.module.unions:
On 2017/02/03 00:31:45, yzshen1 wrote:
> We should also consider enum typemapping, right? Enums could be standalone,
> inside structs, insides interfaces.

This is used to generate the list of traits headers needed by a .mojom.cc file.
The traits header is only required if a type is serialised within that file,
which is only when a struct, union or interface within that mojom file contains
the type. This is why the structs and unions defined within the file are
skipped. Added a comment explaining this.

[yzshen1, 2017-02-07 00:21:45]

LGTM with one nit. Thanks!

https://codereview.chromium.org/2656583002/diff/300001/mojo/public/tools/bind...
File mojo/public/tools/bindings/generators/mojom_cpp_generator.py (right):

https://codereview.chromium.org/2656583002/diff/300001/mojo/public/tools/bind...
mojo/public/tools/bindings/generators/mojom_cpp_generator.py:589: A type is
needed for serialization if it is contained by a struct or enum
enum -> union?

[Sam McNally, 2017-02-07 00:30:59]

Description was changed from

==========
Remove some unused includes from generated C++ mojo bindings.

This restricts additional headers from typemaps to only types that are
used within the mojom. It also removes some unnecessary standard
bindings headers, e.g. <unordered_map> when a mojom contains no maps.

BUG=652404
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove unused typemap includes from generated C++ mojo bindings.

This restricts additional headers from typemaps to only types that are
used within the mojom.

BUG=652404
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Sam McNally, 2017-02-07 00:31:20]

Description was changed from

==========
Remove unused typemap includes from generated C++ mojo bindings.

This restricts additional headers from typemaps to only types that are
used within the mojom.

BUG=652404
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove unused typemap includes from generated C++ mojo bindings.

This restricts additional headers from typemaps to only types that are
used within the mojom.

BUG=652404
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Sam McNally, 2017-02-07 00:36:14]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 00:37:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2017-02-07 01:48:30]

sammc@chromium.org changed reviewers:
+ dcheng@chromium.org, jam@chromium.org

[Sam McNally, 2017-02-07 01:48:31]

+jam for everything outside //mojo

+dcheng for traits, typemaps and type converters

https://codereview.chromium.org/2656583002/diff/300001/mojo/public/tools/bind...
File mojo/public/tools/bindings/generators/mojom_cpp_generator.py (right):

https://codereview.chromium.org/2656583002/diff/300001/mojo/public/tools/bind...
mojo/public/tools/bindings/generators/mojom_cpp_generator.py:589: A type is
needed for serialization if it is contained by a struct or enum
On 2017/02/07 00:21:45, yzshen1 wrote:
> enum -> union?

Done.

[commit-bot: I haz the power, 2017-02-07 02:51:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 02:51:52]

Dry run: This issue passed the CQ dry run.

[dcheng, 2017-02-07 07:50:13]

rs lgtm for mojo security

[jam, 2017-02-07 17:44:08]

lgtm

[Sam McNally, 2017-02-07 22:06:32]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2017-02-07 22:06:33]

The patchset sent to the CQ was uploaded after l-g-t-m from yzshen@chromium.org
Link to the patchset: https://codereview.chromium.org/2656583002/#ps320001
(title: " ")

[commit-bot: I haz the power, 2017-02-07 22:07:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 22:22:07]

CQ is committing da patch.

Bot data: {"patchset_id": 320001, "attempt_start_ts": 1486505192737460,
"parent_rev": "7280dbb030e5a867689c2c152748d8885e085c70", "commit_rev":
"406822fa3d00ff5aeb7afa2099abff3d2672d3c9"}

[commit-bot: I haz the power, 2017-02-07 22:22:38]

Description was changed from

==========
Remove unused typemap includes from generated C++ mojo bindings.

This restricts additional headers from typemaps to only types that are
used within the mojom.

BUG=652404
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Remove unused typemap includes from generated C++ mojo bindings.

This restricts additional headers from typemaps to only types that are
used within the mojom.

BUG=652404
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2656583002
Cr-Commit-Position: refs/heads/master@{#448740}
Committed:
https://chromium.googlesource.com/chromium/src/+/406822fa3d00ff5aeb7afa2099ab...
==========

[commit-bot: I haz the power, 2017-02-07 22:22:40]

Committed patchset #16 (id:320001) as
https://chromium.googlesource.com/chromium/src/+/406822fa3d00ff5aeb7afa2099ab...