Remove unused typemap includes from generated C++ mojo bindings.

mojo/public/tools/bindings/generators/mojom_cpp_generator.py

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Generates C++ source files from a mojom.Module."""
 
 import mojom.generate.generator as generator
 import mojom.generate.module as mojom
 import mojom.generate.pack as pack
 from mojom.generate.template_expander import UseJinja
@@ skipping 169 matching lines @@
   """
   checked = set()
   def Check(kind):
     if kind.spec in checked:
       return True
     checked.add(kind.spec)
     if mojom.IsNullableKind(kind):
       return False
     elif mojom.IsStructKind(kind):
       if (IsTypemappedKind(kind) and
-          not _current_typemap[GetFullMojomNameForKind(kind)]["hashable"]):
+          not _current_typemap[ GetFullMojomNameForKind(kind)]["hashable"]):

[yzshen1, 2017/02/03 00:31:45]

nit: the empty space is not needed.

[Sam McNally, 2017/02/03 02:28:32]

Done.

         return False
       return all(Check(field.kind) for field in kind.fields)
     elif mojom.IsEnumKind(kind):
-      if (IsTypemappedKind(kind) and
-          not _current_typemap[GetFullMojomNameForKind(kind)]["hashable"]):
-        return False
-      return True
+      return not (IsTypemappedKind(kind) and not _current_typemap[

[yzshen1, 2017/02/03 00:31:45]

It seems a little easier to read with
"return not XXX or YYY"

[Sam McNally, 2017/02/03 02:28:32]

Done.

+          GetFullMojomNameForKind(kind)]["hashable"])
     elif mojom.IsUnionKind(kind):
       return all(Check(field.kind) for field in kind.fields)
     elif mojom.IsAnyHandleKind(kind):
       return False
     elif mojom.IsAnyInterfaceKind(kind):
       return False
     # TODO(tibell): Arrays and maps could be made hashable. We just don't have a
     # use case yet.
     elif mojom.IsArrayKind(kind):
       return False
@@ skipping 204 matching lines @@
     return "mojo::ScopedMessagePipeHandle"
   if mojom.IsSharedBufferKind(kind):
     return "mojo::ScopedSharedBufferHandle"
   return _kind_to_cpp_type[kind]
 
 def GetUnmappedTypeForSerializer(kind):
   return GetCppDataViewType(kind, qualified=True)
 
 def TranslateConstants(token, kind):
   if isinstance(token, mojom.NamedValue):
-    return _NameFormatter(token, _variant).FormatForCpp(
-        flatten_nested_kind=True)
+    return GetNameForKind(token, flatten_nested_kind=True)
 
   if isinstance(token, mojom.BuiltinValue):
     if token.value == "double.INFINITY":
       return "std::numeric_limits<double>::infinity()"
     if token.value == "float.INFINITY":
       return "std::numeric_limits<float>::infinity()"
     if token.value == "double.NEGATIVE_INFINITY":
       return "-std::numeric_limits<double>::infinity()"
     if token.value == "float.NEGATIVE_INFINITY":
       return "-std::numeric_limits<float>::infinity()"
@@ skipping 89 matching lines @@
     return "%d, %s" % (expected_num_elements, enum_validate_func)
 
 def GetNewContainerValidateParams(kind):
   if (not mojom.IsArrayKind(kind) and not mojom.IsMapKind(kind) and
       not mojom.IsStringKind(kind)):
     return "nullptr"
 
   return "new mojo::internal::ContainerValidateParams(%s)" % (
       GetContainerValidateParamsCtorArgs(kind))
 
+
+def QuoteHeader(header):
+  if header[0] == '<':
+    return header
+  return '"%s"' % header
+
+
+def QuoteAndSortHeaders(headers):
+  return (QuoteHeader(header) for header in sorted(headers))
+
+
+CHROMIUM_HEADERS = {
+    "array": ["<vector>"],

[yzshen1, 2017/02/02 22:33:58]

(Not saying that I have a strong preference, just curious) Does it cost much if
we always include these headers, and only selectively include those files for
typemapping?

[Sam McNally, 2017/02/03 02:28:32]

Perf-wise, probably not too much. Including a .mojom.h file does pull in a lot
of other headers though, which makes IWYU harder. That's probably a lost cause
until modules solve everything.

I'll split it out from this CL at least.

+    "interface": [
+          "base/callback.h",
+          "mojo/public/cpp/bindings/associated_interface_ptr.h",
+          "mojo/public/cpp/bindings/associated_interface_ptr_info.h",
+          "mojo/public/cpp/bindings/associated_interface_request.h",
+          "mojo/public/cpp/bindings/interface_ptr.h",
+          "mojo/public/cpp/bindings/interface_request.h",
+          "mojo/public/cpp/bindings/raw_ptr_impl_ref_traits.h",
+          "mojo/public/cpp/bindings/thread_safe_interface_ptr.h",
+        ],
+    "map": ["<unordered_map>"],
+    "native_enum": ["mojo/public/cpp/bindings/native_enum.h"],
+    "native_struct": ["mojo/public/cpp/bindings/native_struct.h"],
+    "optional": ["base/optional.h"],
+    "string": ["<string>"],
+    "struct": [
+        "<vector>",
+        "mojo/public/cpp/bindings/lib/clone_equals_util.h",
+        "mojo/public/cpp/bindings/lib/hash_util.h",
+        "mojo/public/cpp/bindings/struct_ptr.h",
+        "mojo/public/cpp/bindings/struct_traits.h",
+    ],
+    "union": [
+        "<vector>",
+        "mojo/public/cpp/bindings/lib/union_accessor.h",
+        "mojo/public/cpp/bindings/union_traits.h",
+    ],
+}
+
+BLINK_HEADERS = {
+    "array": ["third_party/WebKit/Source/wtf/Vector.h"],
+    "interface": [
+          "base/callback.h",
+          "mojo/public/cpp/bindings/associated_interface_ptr.h",
+          "mojo/public/cpp/bindings/associated_interface_ptr_info.h",
+          "mojo/public/cpp/bindings/associated_interface_request.h",
+          "mojo/public/cpp/bindings/interface_ptr.h",
+          "mojo/public/cpp/bindings/interface_request.h",
+          "mojo/public/cpp/bindings/raw_ptr_impl_ref_traits.h",
+          "mojo/public/cpp/bindings/thread_safe_interface_ptr.h",
+        ],
+    "map": ["third_party/WebKit/Source/wtf/HashMap.h"],
+    "native_enum": ["mojo/public/cpp/bindings/native_enum.h"],
+    "native_struct": ["mojo/public/cpp/bindings/native_struct.h"],
+    "optional": ["third_party/WebKit/Source/wtf/Optional.h"],
+    "string": ["third_party/WebKit/Source/wtf/text/WTFString.h"],
+    "struct": [
+        "third_party/WebKit/Source/wtf/Vector.h",
+        "mojo/public/cpp/bindings/struct_ptr.h",
+        "mojo/public/cpp/bindings/struct_traits.h",
+        "mojo/public/cpp/bindings/lib/wtf_clone_equals_util.h",
+        "mojo/public/cpp/bindings/lib/wtf_hash_util.h",
+    ],
+    "union": [
+        "mojo/public/cpp/bindings/lib/union_accessor.h",
+        "mojo/public/cpp/bindings/union_traits.h",
+        "third_party/WebKit/Source/wtf/Vector.h",
+    ],
+}
+
+SHARED_HEADERS = {
+    "array": ["mojo/public/cpp/bindings/array_data_view.h"],
+    "enum": ["mojo/public/cpp/bindings/enum_traits.h"],
+    "interface": ["mojo/public/cpp/bindings/interface_data_view.h"],
+    "map": ["mojo/public/cpp/bindings/map_data_view.h"],
+    "native_enum": ["mojo/public/cpp/bindings/native_enum.h"],
+    "native_struct": ["mojo/public/cpp/bindings/native_struct_data_view.h"],
+    "non_native_enum": ["<ostream>"],
+    "string": ["mojo/public/cpp/bindings/string_data_view.h"],
+}
+
+
 class Generator(generator.Generator):
 
   cpp_filters = {
     "constant_value": ConstantValue,
     "contains_handles_or_interfaces": mojom.ContainsHandlesOrInterfaces,
     "contains_move_only_members": ContainsMoveOnlyMembers,
     "cpp_wrapper_param_type": GetCppWrapperParamType,
     "cpp_data_view_type": GetCppDataViewType,
     "cpp_field_type": GetCppFieldType,
     "cpp_union_field_type": GetCppUnionFieldType,
@@ skipping 25 matching lines @@
     "is_hashable": IsHashableKind,
     "is_map_kind": mojom.IsMapKind,
     "is_nullable_kind": mojom.IsNullableKind,
     "is_object_kind": mojom.IsObjectKind,
     "is_reference_kind": mojom.IsReferenceKind,
     "is_string_kind": mojom.IsStringKind,
     "is_struct_kind": mojom.IsStructKind,
     "is_typemapped_kind": IsTypemappedKind,
     "is_union_kind": mojom.IsUnionKind,
     "passes_associated_kinds": mojom.PassesAssociatedKinds,
-    "struct_size": lambda ps: ps.GetTotalSize() + _HEADER_SIZE,
     "stylize_method": generator.StudlyCapsToCamel,
     "under_to_camel": generator.UnderToCamel,
     "unmapped_type_for_serializer": GetUnmappedTypeForSerializer,
   }
 
   def GetExtraTraitsHeaders(self):
     extra_headers = set()
-    for entry in self.typemap.itervalues():
-      extra_headers.update(entry.get("traits_headers", []))
-    return list(extra_headers)
+    for typemap in self._GetAllUsedTypemaps():
+      extra_headers.update(typemap.get("traits_headers", []))
+    return QuoteAndSortHeaders(extra_headers)
 
-  def GetExtraPublicHeaders(self):
-    extra_headers = set()
-    for entry in self.typemap.itervalues():
-      extra_headers.update(entry.get("public_headers", []))
-    return list(extra_headers)
+  def _GetAllUsedTypemaps(self):
+    used_typemaps = []
+    seen_types = set()
+    def AddKind(kind):
+      if (mojom.IsIntegralKind(kind) or mojom.IsStringKind(kind) or
+          mojom.IsDoubleKind(kind) or mojom.IsFloatKind(kind) or
+          mojom.IsAnyHandleKind(kind) or
+          mojom.IsInterfaceKind(kind) or
+          mojom.IsInterfaceRequestKind(kind) or
+          mojom.IsAssociatedKind(kind)):
+        pass
+      elif mojom.IsArrayKind(kind):
+        AddKind(kind.kind)
+      elif mojom.IsMapKind(kind):
+        AddKind(kind.key_kind)
+        AddKind(kind.value_kind)
+      else:
+        name = GetFullMojomNameForKind(kind)
+        if name in seen_types:
+          return
+        seen_types.add(name)
+
+        typemap = _current_typemap.get(name, None)
+        if typemap:
+          used_typemaps.append(typemap)
+        if mojom.IsStructKind(kind) or mojom.IsUnionKind(kind):
+          for field in kind.fields:
+            AddKind(field.kind)
+
+    for kind in self.module.structs + self.module.unions:

[yzshen1, 2017/02/03 00:31:45]

We should also consider enum typemapping, right? Enums could be standalone,
inside structs, insides interfaces.

[Sam McNally, 2017/02/03 02:28:32]

This is used to generate the list of traits headers needed by a .mojom.cc file.
The traits header is only required if a type is serialised within that file,
which is only when a struct, union or interface within that mojom file contains
the type. This is why the structs and unions defined within the file are
skipped. Added a comment explaining this.

+      for field in kind.fields:
+        AddKind(field.kind)
+
+    for interface in self.module.interfaces:
+      for method in interface.methods:
+        for parameter in method.parameters + (method.response_parameters or []):
+          AddKind(parameter.kind)
+
+    return used_typemaps
+
+  def _GetPublicHeadersImpl(self, header_type_to_headers):
+    header_types = set()
+    headers = set()
+
+    if self.module.structs:
+      header_types.add('struct')
+    if self.module.unions:
+      header_types.add('union')
+    if self.module.interfaces:
+      header_types.add('interface')
+
+    all_enums = list(self.module.enums)
+    for struct in self.module.structs:
+      all_enums.extend(struct.enums)
+    for interface in self.module.interfaces:
+      all_enums.extend(interface.enums)
+
+    potential_types = set(GetFullMojomNameForKind(typename)
+                          for typename in
+                          self.module.structs + all_enums + self.module.unions)
+    for key, entry in self.typemap.iteritems():
+      if key in potential_types:
+        headers.update(entry.get("public_headers", []))
+    if all_enums:
+      header_types.add('enum')
+    native_enums = [enum.native_only for enum in all_enums]
+    if native_enums:
+      header_types.add('native_enum')
+    if len(native_enums) != len(all_enums):
+      header_types.add('non_native_enum')
+
+    if any(struct.native_only for struct in self.module.structs):
+      header_types.add('native_struct')
+    for kind in self._GetDirectlyUsedKinds():
+      if hasattr(kind, 'is_nullable') and kind.is_nullable:
+        header_types.add('optional')
+      if mojom.IsStringKind(kind):
+        header_types.add('string')
+      elif mojom.IsArrayKind(kind):
+        header_types.add('array')
+      elif mojom.IsMapKind(kind):
+        header_types.add('map')
+    for header_type in header_types:
+      headers.update(header_type_to_headers.get(header_type, []))
+    return QuoteAndSortHeaders(headers)
+
+  def GetPublicHeaders(self):
+    return self._GetPublicHeadersImpl(
+        BLINK_HEADERS if self.for_blink else CHROMIUM_HEADERS)
+
+  def GetPublicSharedHeaders(self):
+    return self._GetPublicHeadersImpl(SHARED_HEADERS)
+
+  def _GetDirectlyUsedKinds(self):
+    for struct in self.module.structs + self.module.unions:
+      for field in struct.fields:
+        yield field.kind
+
+    for interface in self.module.interfaces:
+      for method in interface.methods:
+        for param in method.parameters + (method.response_parameters or []):
+          yield param.kind
 
   def GetJinjaExports(self):
     structs = self.GetStructs()
     interfaces = self.GetInterfaces()
     all_enums = list(self.module.enums)
     for struct in structs:
       all_enums.extend(struct.enums)
     for interface in interfaces:
       all_enums.extend(interface.enums)
 
     return {
       "module": self.module,
       "namespace": self.module.namespace,
       "namespaces_as_array": NamespaceToArray(self.module.namespace),
       "imports": self.module.imports,
       "kinds": self.module.kinds,
       "enums": self.module.enums,
       "all_enums": all_enums,
       "structs": structs,
       "unions": self.GetUnions(),
       "interfaces": interfaces,
       "variant": self.variant,
       "extra_traits_headers": self.GetExtraTraitsHeaders(),
-      "extra_public_headers": self.GetExtraPublicHeaders(),
+      "public_headers": self.GetPublicHeaders(),
+      "public_shared_headers": self.GetPublicSharedHeaders(),
       "for_blink": self.for_blink,
       "use_once_callback": self.use_once_callback,
       "export_attribute": self.export_attribute,
       "export_header": self.export_header,
     }
 
   @staticmethod
   def GetTemplatePrefix():
     return "cpp_templates"
 
@@ skipping 38 matching lines @@
       global _use_once_callback
       _use_once_callback = self.use_once_callback
       global _variant
       _variant = self.variant
       suffix = "-%s" % self.variant if self.variant else ""
       self.Write(self.GenerateModuleHeader(),
                  self.MatchMojomFilePath("%s%s.h" % (self.module.name, suffix)))
       self.Write(
           self.GenerateModuleSource(),
           self.MatchMojomFilePath("%s%s.cc" % (self.module.name, suffix)))