Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issue 2656533004: Remove unused blink::FeaturePolicy class. (Closed)

Created:
3 years, 11 months ago by iclelland
Modified:
3 years, 9 months ago
Reviewers:
haraken, raymes
CC:
chromium-reviews, tyoshino+watch_chromium.org, loading-reviews_chromium.org, fuzzing_chromium.org, gavinp+loader_chromium.org, lunalu1, blink-reviews, kinuko+watch, Nate Chapin
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused blink::FeaturePolicy class. This is part 5 of 5 in the effort to move the FeaturePolicy implementation into the content layer, which will facilitate use of the framework for browser- based policy decisions. See the other CLs in this series: [1/5] https://codereview.chromium.org/2648423002/ (Rename classes) [2/5] https://codereview.chromium.org/2654873004/ (Centralize content-side code) [3/5] https://codereview.chromium.org/2655663004/ (Maintain parallel FP in browser) [4/5] https://codereview.chromium.org/2651883008/ (Use content/ FP in blink) [5/5] (This CL) (Remove unused blink code.) BUG=685195 Review-Url: https://codereview.chromium.org/2656533004 Cr-Commit-Position: refs/heads/master@{#455152} Committed: https://chromium.googlesource.com/chromium/src/+/419a628d898182f01fe1974bca078351ef4660cb

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Update for HTMLIFrameElementAllow #

Patch Set 4 : Rebase, remove unneeded includes #

Patch Set 5 : Rebase before commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -1574 lines) Patch
M third_party/WebKit/Source/core/html/HTMLIFrameElementAllow.cpp View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 2 3 4 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.h View 1 2 1 chunk +14 lines, -217 lines 0 comments Download
M third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp View 1 2 3 3 chunks +4 lines, -236 lines 0 comments Download
M third_party/WebKit/Source/platform/feature_policy/FeaturePolicyFuzzer.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/feature_policy/FeaturePolicyTest.cpp View 1 2 3 chunks +33 lines, -1112 lines 0 comments Download

Messages

Total messages: 26 (19 generated)
iclelland
+r raymes This one should be the easiest, I hope :)
3 years, 10 months ago (2017-02-10 05:39:42 UTC) #7
raymes
lgtm https://codereview.chromium.org/2656533004/diff/20001/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp File third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp (right): https://codereview.chromium.org/2656533004/diff/20001/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp#newcode9 third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp:9: #include "platform/weborigin/KURL.h" nit: can we remove this? https://codereview.chromium.org/2656533004/diff/20001/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp#newcode12 ...
3 years, 10 months ago (2017-02-13 02:42:37 UTC) #8
iclelland
On 2017/02/13 02:42:37, raymes wrote: > lgtm > > https://codereview.chromium.org/2656533004/diff/20001/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp > File third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp > (right): ...
3 years, 9 months ago (2017-03-07 05:44:49 UTC) #17
iclelland
+r haraken, can you PTAL as owner?
3 years, 9 months ago (2017-03-07 05:45:08 UTC) #19
haraken
LGTM
3 years, 9 months ago (2017-03-07 06:29:10 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656533004/80001
3 years, 9 months ago (2017-03-07 15:03:03 UTC) #23
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 18:41:39 UTC) #26
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/419a628d898182f01fe1974bca07...

Powered by Google App Engine
This is Rietveld 408576698