Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1208)

Issue 2656463004: [wasm][asm.js] Allow asm.js->wasm codegen in unsafe-eval situations. (Closed)

Created:
3 years, 11 months ago by bradnelson
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm][asm.js] Allow asm.js->wasm codegen in unsafe-eval situations. A recent change to disallow wasm compilation in contexts where CSP unsafe-eval would disallow eval also ended up banning asm.js there: https://codereview.chromium.org/2646713002 This ends up banning non-evaled asm.js even in some places it should be allowed. NOTE: Although asm.js code converted to wasm generates an intermediate wasm module. asm.js code evaled in a disallowed context can't even get that far (as it's stoped at the eval site). BUG=683867 R=mtrofin@chromium.org,titzer@chromium.org,adamk@chromium.org Review-Url: https://codereview.chromium.org/2656463004 Cr-Commit-Position: refs/heads/master@{#42616} Committed: https://chromium.googlesource.com/v8/v8/+/e53f6469d90b08e8042b120438702a0666f0d331

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
M src/runtime/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/wasm/wasm-module.cc View 1 chunk +2 lines, -1 line 0 comments Download
A test/mjsunit/wasm/asm-with-wasm-off.js View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
bradn
3 years, 11 months ago (2017-01-24 04:26:10 UTC) #4
Mircea Trofin
lgtm
3 years, 11 months ago (2017-01-24 04:40:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656463004/1
3 years, 11 months ago (2017-01-24 04:43:08 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 05:00:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/e53f6469d90b08e8042b120438702a0666f...

Powered by Google App Engine
This is Rietveld 408576698