[wasm] Enable content policy for wasm compilation.

[wasm] Enable content policy for wasm compilation.

Make wasm code generation (including deserialization) aware of 
allow_codegen_callback - if one were set by the host - akin to what we 
do for `eval`.

This allows web pages that opt out of unsafe-eval to also opt out of
wasm scenarios.

BUG=v8:5869
Review-Url: https://codereview.chromium.org/2646713002
Cr-Commit-Position: refs/heads/master@{#42519}
Committed: https://chromium.googlesource.com/v8/v8/+/5e44cc79d54194267197fbe42e9a8b5e2b4d0249

[Mircea Trofin, 2017-01-19 04:34:14]

The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 04:34:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mircea Trofin, 2017-01-19 04:34:55]

Description was changed from

==========
[wasm] Enable content policy for wasm compilation.

BUG=
==========

to

==========
[wasm] Enable content policy for wasm compilation.

BUG=
==========

[Mircea Trofin, 2017-01-19 04:34:55]

mtrofin@chromium.org changed reviewers:
+ bradnelson@chromium.org, jochen@chromium.org

[Mircea Trofin, 2017-01-19 04:46:00]

Description was changed from

==========
[wasm] Enable content policy for wasm compilation.

BUG=
==========

to

==========
[wasm] Enable content policy for wasm compilation.

Make wasm code generation (including deserialization) aware of the host
set allow_codegen_callback - if one were set - akin to what we do for
`eval`.

This allows web pages that opt out of unsafe-eval to also opt out of
wasm scenarios.

Andreas, would throwing RuntimeError make sense in this case?

BUG=
==========

[Mircea Trofin, 2017-01-19 04:46:01]

mtrofin@chromium.org changed reviewers:
+ rossberg@chromium.org

[Mircea Trofin, 2017-01-19 04:46:16]

Description was changed from

==========
[wasm] Enable content policy for wasm compilation.

Make wasm code generation (including deserialization) aware of the host
set allow_codegen_callback - if one were set - akin to what we do for
`eval`.

This allows web pages that opt out of unsafe-eval to also opt out of
wasm scenarios.

Andreas, would throwing RuntimeError make sense in this case?

BUG=
==========

to

==========
[wasm] Enable content policy for wasm compilation.

Make wasm code generation (including deserialization) aware of the host
set allow_codegen_callback - if one were set - akin to what we do for
`eval`.

This allows web pages that opt out of unsafe-eval to also opt out of
wasm scenarios.

BUG=
==========

[Mircea Trofin, 2017-01-19 04:52:44]

Description was changed from

==========
[wasm] Enable content policy for wasm compilation.

Make wasm code generation (including deserialization) aware of the host
set allow_codegen_callback - if one were set - akin to what we do for
`eval`.

This allows web pages that opt out of unsafe-eval to also opt out of
wasm scenarios.

BUG=
==========

to

==========
[wasm] Enable content policy for wasm compilation.

Make wasm code generation (including deserialization) aware of the 
host-set allow_codegen_callback - if one were set - akin to what we do 
for `eval`.

This allows web pages that opt out of unsafe-eval to also opt out of
wasm scenarios.

BUG=
==========

[Mircea Trofin, 2017-01-19 04:53:10]

Description was changed from

==========
[wasm] Enable content policy for wasm compilation.

Make wasm code generation (including deserialization) aware of the 
host-set allow_codegen_callback - if one were set - akin to what we do 
for `eval`.

This allows web pages that opt out of unsafe-eval to also opt out of
wasm scenarios.

BUG=
==========

to

==========
[wasm] Enable content policy for wasm compilation.

Make wasm code generation (including deserialization) aware of 
allow_codegen_callback - if one were set by the host - akin to what we 
do for `eval`.

This allows web pages that opt out of unsafe-eval to also opt out of
wasm scenarios.

BUG=
==========

[commit-bot: I haz the power, 2017-01-19 05:27:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 05:27:45]

Dry run: This issue passed the CQ dry run.

[Mircea Trofin, 2017-01-19 16:23:56]

Andreas - does throwing RuntimeError make sense in the case when the host
disables code generation?

For context, this is part of the wasm ship unblocker described by Seth. 

The change is conservatively extending the new semantics applied for compile
("CSP awareness") to also encompass deserialization, under the argument that
deserializing is a form of code generation. 

While that feature (deserialization, via structured cloning) is currently
disabled in Chrome, I want to avoid a bypass of the CSP directives through
deserialization, when we reenable it.

Adding more folks from the snapshot owners list for the change there.

[Mircea Trofin, 2017-01-19 16:28:36]

Description was changed from

==========
[wasm] Enable content policy for wasm compilation.

Make wasm code generation (including deserialization) aware of 
allow_codegen_callback - if one were set by the host - akin to what we 
do for `eval`.

This allows web pages that opt out of unsafe-eval to also opt out of
wasm scenarios.

BUG=
==========

to

==========
[wasm] Enable content policy for wasm compilation.

Make wasm code generation (including deserialization) aware of 
allow_codegen_callback - if one were set by the host - akin to what we 
do for `eval`.

This allows web pages that opt out of unsafe-eval to also opt out of
wasm scenarios.

BUG=v8:5869
==========

[Yang, 2017-01-19 16:34:44]

yangguo@chromium.org changed reviewers:
+ yangguo@chromium.org

[Yang, 2017-01-19 16:34:45]

src/snapshot lgtm

[rossberg, 2017-01-19 16:39:18]

> Andreas - does throwing RuntimeError make sense in the case when the host
> disables code generation?

RuntimeError is meant to correspond to a Wasm trap, so it doesn't fit here. If a
Wasm exception at all, CompileError probably is more adequate, although that is
meant to indicate a decoding/validation error. The problem is outside Wasm
itself, so a plain JS error might be best, e.g., TypeError.

[Mircea Trofin, 2017-01-19 16:41:02]

The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 16:41:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mircea Trofin, 2017-01-19 16:41:38]

RuntimeError -> TypeError

[Yang, 2017-01-19 16:43:05]

On 2017/01/19 16:41:38, Mircea Trofin wrote:
> RuntimeError -> TypeError

jfyi in the eval case we got an EvalError

[rossberg, 2017-01-19 16:48:01]

On 2017/01/19 16:43:05, Yang wrote:
> On 2017/01/19 16:41:38, Mircea Trofin wrote:
> > RuntimeError -> TypeError
> 
> jfyi in the eval case we got an EvalError

Yeah, on second thought, CompileError seems clearer. Arguably, it is in the same
class as hitting an implementation limit when compiling a module, just that the
limit is, like, zero.

Sorry for the churn.

[Mircea Trofin, 2017-01-19 16:48:19]

On 2017/01/19 16:43:05, Yang wrote:
> On 2017/01/19 16:41:38, Mircea Trofin wrote:
> > RuntimeError -> TypeError
> 
> jfyi in the eval case we got an EvalError

Thanks. The hope is to have a separate CSP-like directive for wasm, than the one
for plain JS, so long-term, EvalError may not be as representative.

[Mircea Trofin, 2017-01-19 16:49:23]

The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 16:49:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mircea Trofin, 2017-01-19 16:49:43]

*Error -> CompileError

[bradnelson, 2017-01-19 17:09:48]

Wasm part lgtm

[jochen (gone - plz use gerrit), 2017-01-19 17:10:13]

lgtm

[commit-bot: I haz the power, 2017-01-19 17:20:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 17:20:54]

Dry run: This issue passed the CQ dry run.

[Mircea Trofin, 2017-01-19 17:28:21]

The CQ bit was checked by mtrofin@chromium.org

[Mircea Trofin, 2017-01-19 17:28:22]

The patchset sent to the CQ was uploaded after l-g-t-m from yangguo@chromium.org
Link to the patchset: https://codereview.chromium.org/2646713002/#ps40001
(title: "CompileError")

[commit-bot: I haz the power, 2017-01-19 17:28:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 17:30:31]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484846901855300,
"parent_rev": "26c4a9cc898c38de608757816f625166f95e66eb", "commit_rev":
"5e44cc79d54194267197fbe42e9a8b5e2b4d0249"}

[commit-bot: I haz the power, 2017-01-19 17:30:34]

Description was changed from

==========
[wasm] Enable content policy for wasm compilation.

Make wasm code generation (including deserialization) aware of 
allow_codegen_callback - if one were set by the host - akin to what we 
do for `eval`.

This allows web pages that opt out of unsafe-eval to also opt out of
wasm scenarios.

BUG=v8:5869
==========

to

==========
[wasm] Enable content policy for wasm compilation.

Make wasm code generation (including deserialization) aware of 
allow_codegen_callback - if one were set by the host - akin to what we 
do for `eval`.

This allows web pages that opt out of unsafe-eval to also opt out of
wasm scenarios.

BUG=v8:5869

Review-Url: https://codereview.chromium.org/2646713002
Cr-Commit-Position: refs/heads/master@{#42519}
Committed:
https://chromium.googlesource.com/v8/v8/+/5e44cc79d54194267197fbe42e9a8b5e2b4...
==========

[commit-bot: I haz the power, 2017-01-19 17:30:35]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/5e44cc79d54194267197fbe42e9a8b5e2b4...