Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2656373002: Revert of Enable HTTP/0.9 on non-standard ports by default (Closed)

Created:
3 years, 10 months ago by mmenke
Modified:
3 years, 10 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable HTTP/0.9 on non-standard ports by default (patchset #2 id:20001 of https://codereview.chromium.org/2651753002/ ) Reason for revert: Removing to apply the CL with Shoutcast detection in its place Original issue's description: > Enable HTTP/0.9 on non-standard ports by default > > This is a temporary patch to enable HTTP/0.9 on non-standard ports by > default. After merging it with Chrome 56, it will be reverted, in favor > of specifically adding detection of Shoutcast servers on HTTP ports > other than port 80. > > BUG=669800 > > Review-Url: https://codereview.chromium.org/2651753002 > Cr-Commit-Position: refs/heads/master@{#445743} > Committed: https://chromium.googlesource.com/chromium/src/+/2617c4a136497244376e1bcf11aa356afb2a1e06 TBR=eroman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=669800 Review-Url: https://codereview.chromium.org/2656373002 Cr-Commit-Position: refs/heads/master@{#446825} Committed: https://chromium.googlesource.com/chromium/src/+/82d19a580c72707597f9e3e60d9f55f271c51317

Patch Set 1 #

Patch Set 2 : merge #

Patch Set 3 : Oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M chrome/browser/io_thread.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/errorpage_browsertest.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M net/http/http_network_session.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
mmenke
Created Revert of Enable HTTP/0.9 on non-standard ports by default
3 years, 10 months ago (2017-01-27 17:22:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656373002/1
3 years, 10 months ago (2017-01-27 17:22:45 UTC) #3
commit-bot: I haz the power
Failed to apply patch for net/http/http_network_session.cc: While running git apply --index -p1; error: patch failed: ...
3 years, 10 months ago (2017-01-27 19:15:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656373002/100002
3 years, 10 months ago (2017-01-27 19:25:11 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/222217)
3 years, 10 months ago (2017-01-27 21:51:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2656373002/100002
3 years, 10 months ago (2017-01-27 21:53:01 UTC) #11
eroman
lgtm
3 years, 10 months ago (2017-01-27 22:13:32 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 23:27:18 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:100002) as
https://chromium.googlesource.com/chromium/src/+/82d19a580c72707597f9e3e60d9f...

Powered by Google App Engine
This is Rietveld 408576698