Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2651753002: Enable HTTP/0.9 on non-standard ports by default (Closed)

Created:
3 years, 11 months ago by mmenke
Modified:
3 years, 11 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable HTTP/0.9 on non-standard ports by default This is a temporary patch to enable HTTP/0.9 on non-standard ports by default. After merging it with Chrome 56, it will be reverted, in favor of specifically adding detection of Shoutcast servers on HTTP ports other than port 80. BUG=669800 Review-Url: https://codereview.chromium.org/2651753002 Cr-Commit-Position: refs/heads/master@{#445743} Committed: https://chromium.googlesource.com/chromium/src/+/2617c4a136497244376e1bcf11aa356afb2a1e06

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/browser/io_thread.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/errorpage_browsertest.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download
M net/http/http_network_session.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (14 generated)
mmenke
Eric: I want to land this, merge it with M56, and revert it, so it's ...
3 years, 11 months ago (2017-01-23 22:30:36 UTC) #10
eroman
LGTM. Note that you could patch directly to the 56 branch
3 years, 11 months ago (2017-01-24 00:22:25 UTC) #12
mmenke
On 2017/01/24 00:22:25, eroman (slow) wrote: > LGTM. > > Note that you could patch ...
3 years, 11 months ago (2017-01-24 15:45:41 UTC) #13
mmenke
On 2017/01/24 15:45:41, mmenke wrote: > On 2017/01/24 00:22:25, eroman (slow) wrote: > > LGTM. ...
3 years, 11 months ago (2017-01-24 15:49:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2651753002/20001
3 years, 11 months ago (2017-01-24 16:49:40 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/2617c4a136497244376e1bcf11aa356afb2a1e06
3 years, 11 months ago (2017-01-24 16:54:38 UTC) #20
mmenke
3 years, 10 months ago (2017-01-27 17:22:13 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2656373002/ by mmenke@chromium.org.

The reason for reverting is: Removing to apply the CL with Shoutcast detection
in its place.

Powered by Google App Engine
This is Rietveld 408576698