[Typed CSSOM] Support line height in ComputedStylePropertyMap

[Typed CSSOM] Support line height in ComputedStylePropertyMap

Line height is represented as a Length in ComputedStyle, but the Length value is used to encode what are actually number and keyword values. So it has to be handled as a special case.

Depends on https://codereview.chromium.org/2403423002/.

BUG=648495
Review-Url: https://codereview.chromium.org/2656253002
Cr-Commit-Position: refs/heads/master@{#450564}
Committed: https://chromium.googlesource.com/chromium/src/+/2d511bceabaa2c2a7e53dea20277cb45e08255f5

[rjwright, 2017-01-27 00:15:02]

Description was changed from

==========
[Typed CSSOM] Support line height in ComputedStylePropertyMap
BUG=648495
==========

to

==========
[Typed CSSOM] Support line height in ComputedStylePropertyMap

Line height is represented as a Length in ComputedStyle, but the Length value is
used to encode what are actually number and keyword values. So it has to be
handled as a special case.

Depends on https://codereview.chromium.org/2403423002/.

BUG=648495
==========

[rjwright, 2017-01-27 00:15:02]

rjwright@chromium.org changed reviewers:
+ meade@chromium.org

[meade_UTC10, 2017-01-27 06:17:10]

If this depends on the other CL, could you please make it a dependent patchset
of the other? It's too hard to review like this.

git reparent-branch <other branch>

[rjwright, 2017-01-27 19:10:49]

On 2017/01/27 06:17:10, Eddy wrote:
> If this depends on the other CL, could you please make it a dependent patchset
> of the other? It's too hard to review like this.
> 
> git reparent-branch <other branch>

Sorry, I didn't expect you to review it like this. I was going to just wait till
the first one landed. I will just reparent it now though.

[rjwright, 2017-01-27 22:49:41]

On 2017/01/27 19:10:49, rjwright wrote:
> On 2017/01/27 06:17:10, Eddy wrote:
> > If this depends on the other CL, could you please make it a dependent
patchset
> > of the other? It's too hard to review like this.
> > 
> > git reparent-branch <other branch>
> 
> Sorry, I didn't expect you to review it like this. I was going to just wait
till
> the first one landed. I will just reparent it now though.

OK Eddy, ptal :)

[meade_UTC10, 2017-02-09 06:50:48]

lgtm

https://codereview.chromium.org/2656253002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp
(right):

https://codereview.chromium.org/2656253002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:113: //
percents.
WTF... (no action required)

[rjwright, 2017-02-15 01:48:48]

On 2017/02/09 06:50:48, Eddy wrote:
> lgtm
> 
>
https://codereview.chromium.org/2656253002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp
> (right):
> 
>
https://codereview.chromium.org/2656253002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp:113: //
> percents.
> WTF... (no action required)

I know, right.

[rjwright, 2017-02-15 01:54:51]

The CQ bit was checked by rjwright@chromium.org

[commit-bot: I haz the power, 2017-02-15 01:56:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 05:39:20]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487123691773290,
"parent_rev": "cd398136c4992574a2161d68acb39c716095eedd", "commit_rev":
"2d511bceabaa2c2a7e53dea20277cb45e08255f5"}

[commit-bot: I haz the power, 2017-02-15 05:40:49]

Description was changed from

==========
[Typed CSSOM] Support line height in ComputedStylePropertyMap

Line height is represented as a Length in ComputedStyle, but the Length value is
used to encode what are actually number and keyword values. So it has to be
handled as a special case.

Depends on https://codereview.chromium.org/2403423002/.

BUG=648495
==========

to

==========
[Typed CSSOM] Support line height in ComputedStylePropertyMap

Line height is represented as a Length in ComputedStyle, but the Length value is
used to encode what are actually number and keyword values. So it has to be
handled as a special case.

Depends on https://codereview.chromium.org/2403423002/.

BUG=648495

Review-Url: https://codereview.chromium.org/2656253002
Cr-Commit-Position: refs/heads/master@{#450564}
Committed:
https://chromium.googlesource.com/chromium/src/+/2d511bceabaa2c2a7e53dea20277...
==========

[commit-bot: I haz the power, 2017-02-15 05:40:50]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2d511bceabaa2c2a7e53dea20277...