[Typed CSSOM] Support line height in ComputedStylePropertyMap

third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp

 // Copyright 2016 the Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/css/cssom/ComputedStylePropertyMap.h"
 
 #include "core/css/CSSComputedStyleDeclaration.h"
 #include "core/css/ComputedStyleCSSValueMapping.h"
 #include "core/css/cssom/CSSCalcLength.h"
 #include "core/css/cssom/CSSKeywordValue.h"
+#include "core/css/cssom/CSSNumberValue.h"
 #include "core/css/cssom/CSSSimpleLength.h"
 #include "core/css/cssom/CSSUnsupportedStyleValue.h"
 #include "core/css/cssom/StyleValueFactory.h"
 #include "core/css/resolver/StyleResolver.h"
 #include "core/dom/PseudoElement.h"
 #include "core/dom/StyleEngine.h"
 
 namespace blink {
 
 namespace {
@@ skipping 77 matching lines @@
       break;
     case CSSPropertyBottom:
       styleValue = styleValueForLength(style->bottom());
       break;
     case CSSPropertyHeight:
       styleValue = styleValueForLength(style->height());
       break;
     case CSSPropertyWidth:
       styleValue = styleValueForLength(style->width());
       break;
+    case CSSPropertyLineHeight: {
+      // LineHeight is represented as a Length in ComputedStyle, even though it
+      // can be a number or the "normal" keyword. "normal" is encoded as a
+      // negative percent, and numbers (which must be positive) are encoded as
+      // percents.

[meade_UTC10, 2017/02/09 06:50:48]

WTF... (no action required)

+      Length lineHeight = style->lineHeight();
+      if (lineHeight.isNegative()) {
+        styleValue = CSSKeywordValue::create("normal");
+        break;
+      }
+      if (lineHeight.isPercent()) {
+        styleValue = CSSNumberValue::create(lineHeight.percent());
+        break;
+      }
+      if (lineHeight.isFixed()) {
+        styleValue = CSSSimpleLength::create(
+            lineHeight.pixels(), CSSPrimitiveValue::UnitType::Pixels);
+        break;
+      }
+      NOTREACHED();
+      break;
+    }
     default:
       // TODO(rjwright): Add a flag argument to
       // ComputedStyleCSSValyeMapping::get that makes it return
       // just the raw value off the ComputedStyle, and not zoom adjusted or
       // anything like that.
       const CSSValue* value = ComputedStyleCSSValueMapping::get(
           propertyID, *style, nullptr, node, false);
       if (value) {
         return StyleValueFactory::cssValueToStyleValueVector(propertyID,
                                                              *value);
@@ skipping 19 matching lines @@
 
 Vector<String> ComputedStylePropertyMap::getProperties() {
   Vector<String> result;
   for (unsigned i = 0; i < m_computedStyleDeclaration->length(); i++) {
     result.push_back(m_computedStyleDeclaration->item(i));
   }
   return result;
 }
 
 }  // namespace blink